Changeset 76908 in vbox

Timestamp:

Jan 21, 2019 8:28:43 AM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

128277

Message:

Runtime/posix/serialport-posix: Fix access to pseudo terminals, they fail TIOCMBIC and TIOCMGET with EINVAL

Location:

trunk

Files:

• doc/manual/user_ChangeLogImpl.xml (modified) (1 diff)
• src/VBox/Runtime/r3/posix/serialport-posix.cpp (modified) (2 diffs)

trunk/doc/manual/user_ChangeLogImpl.xml

@@ -53 +53 @@
       </listitem>
 
+      <listitem>
+        <para>Serial: fixed connecting to pseudo terminals on POSIX hosts
+          (6.0.0 regression; bug #18319)</para>
+      </listitem>
+
     </itemizedlist>
   </sect1>

trunk/src/VBox/Runtime/r3/posix/serialport-posix.cpp

@@ -266 +266 @@
                 int fTiocmClear = TIOCM_LOOP;
                 rcPsx = ioctl(pThis->iFd, TIOCMBIC, &fTiocmClear);
-                if (rcPsx == -1)
+                if (rcPsx == -1 && errno != EINVAL) /* Pseudo terminals don't support loopback mode so ignore an error here. */
                     rc = RTErrConvertFromErrno(errno);
             }
@@ -623 +623 @@
         }
     }
-    else if (errno == ENOTTY)
+    else if (errno == ENOTTY || errno == EINVAL)
         rc = VERR_NOT_SUPPORTED;
     else