Changeset 76938 in vbox for trunk/src/VBox/Additions/linux

Timestamp:

Jan 22, 2019 4:50:18 PM (6 years ago)

Author:

vboxsync

Message:

Additions/linux/vboxvideo: Fix incorrect type in assignment sparse warning
bugref:8282: Additions/linux: track kernel changes to vboxvideo in our own tree

Sparse emitted the following warning:
../drivers/staging/vboxvideo/vbox_fb.c:173:27: warning: incorrect type in as

signment (different address spaces)

../drivers/staging/vboxvideo/vbox_fb.c:173:27: expected char [noderef] <a

sn:2>*screen_base

../drivers/staging/vboxvideo/vbox_fb.c:173:27: got void *virtual

The vbox_bo buffer object kernel mapping is handled by a call
to ttm_bo_kmap() prior to the assignment of bo->kmap.virtual to
info->screen_base of type char iomem*.
Casting bo->kmap.virtual to char iomem* in this assignment fixes
the warning.

vboxvideo: Fix address space of expression removal sparse warning

Sparse emitted the following warning:
../drivers/staging/vboxvideo/vbox_main.c:64:25: warning: cast removes address space of expression

vbox->vbva_buffers iomapping is handled by calling vbox_accel_init()
from vbox_hw_init().
force attribute is used in assignment to vbva to fix the warning.

Signed-off-by: Alexander Kapshuk <alexander.kapshuk@…>
Reviewed-by: Hans de Goede <hdegoede@…>
Signed-off-by: Greg Kroah-Hartman <gregkh@…>

Location:

trunk/src/VBox/Additions/linux

Files:

• drm/vbox_fb.c (modified) (1 diff)
• drm/vbox_main.c (modified) (1 diff)
• sharedfolders/lnkops.c (modified) (2 diffs)
• sharedfolders/utils.c (modified) (1 diff)

trunk/src/VBox/Additions/linux/drm/vbox_fb.c

@@ -344 +344 @@
                                sizes->fb_height);
 
-        info->screen_base = bo->kmap.virtual;
+        info->screen_base = (char __iomem *)bo->kmap.virtual;
         info->screen_size = size;
 

trunk/src/VBox/Additions/linux/drm/vbox_main.c

@@ -68 +68 @@
                         continue;
 
-                vbva = (void *)vbox->vbva_buffers + i * VBVA_MIN_BUFFER_SIZE;
+                vbva = (void __force *)vbox->vbva_buffers + i * VBVA_MIN_BUFFER_SIZE;
                 if (!VBoxVBVAEnable(&vbox->vbva_info[i],
                                  vbox->guest_pool, vbva, i)) {

trunk/src/VBox/Additions/linux/sharedfolders/lnkops.c

@@ -36 +36 @@
 #  if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 2, 0)
 static const char *sf_follow_link(struct dentry *dentry, void **cookie)
-#  else
+#elif LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 13)
 static void *sf_follow_link(struct dentry *dentry, struct nameidata *nd)
+#else
+static int sf_follow_link(struct dentry *dentry, struct nameidata *nd)
 #  endif
 {
@@ -61 +63 @@
 #  else
         nd_set_link(nd, error ? ERR_PTR(error) : path);
+# if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 13)
         return NULL;
-#  endif
+# else
+        return 0;
+# endif
+#endif
 }
 
 #  if LINUX_VERSION_CODE < KERNEL_VERSION(4, 2, 0)
+# if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 13)
 static void sf_put_link(struct dentry *dentry, struct nameidata *nd,
                         void *cookie)
+#else
+static void sf_put_link(struct dentry *dentry, struct nameidata *nd)
+#endif
 {
         char *page = nd_get_link(nd);

trunk/src/VBox/Additions/linux/sharedfolders/utils.c

@@ -853 +853 @@
         /* Each new shared folder map gets a new uint64_t identifier,
          * allocated in sequence.  We ASSUME the sequence will not wrap. */
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 26)
         static uint64_t s_u64Sequence = 0;
         uint64_t u64CurrentSequence = ASMAtomicIncU64(&s_u64Sequence);
+#endif
 
         sf_g->bdi.ra_pages = 0; /* No readahead */