Changeset 77049 in vbox for trunk/src/VBox/Additions

Timestamp:

Jan 30, 2019 5:06:07 PM (6 years ago)

Author:

vboxsync

Message:

Additions/linux/installer: mute chcon error output.
ticketref:18221:Getting /cant apply partial context to unlabeled file/ in Version 6.0.0
We do various chcon invocations in the Additions installer to make SELinux
happy on old Fedora/EL distributions which are mostly forgotten, but on which
people may still try to install. The invocations are not even correct on
recent systems, so mute the error output. Do not change them so as not to
break the actual target systems.

Location:

trunk/src/VBox/Additions/linux/installer

Files:

• vboxadd-x11.sh (modified) (3 diffs)
• vboxadd.sh (modified) (2 diffs)

trunk/src/VBox/Additions/linux/installer/vboxadd-x11.sh

@@ -167 +167 @@
                 semanage fcontext -a -t lib_t "/var/lib/VBoxGuestAdditions/lib/libGL.so.1"
             fi
-            chcon -h  -t lib_t "/var/lib/VBoxGuestAdditions/lib/libGL.so.1"
+            # This is needed on old Fedora/Redhat systems.  No one remembers which.
+            chcon -h  -t lib_t "/var/lib/VBoxGuestAdditions/lib/libGL.so.1" 2>/dev/null
         fi
         echo "/var/lib/VBoxGuestAdditions/lib" > /etc/ld.so.conf.d/00vboxvideo.conf
@@ -465 +466 @@
     case "$redhat_release" in
         Fedora\ release\ 8* )
-            chcon -u system_u -t lib_t "${lib_dir}"/*.so
+            chcon -u system_u -t lib_t "${lib_dir}"/*.so 2>/dev/null
             ;;
     esac
@@ -472 +473 @@
     # needs a rule to allow this.  Send all output to /dev/null in case this is
     # completely irrelevant on the target system.
+    # chcon is needed on old Fedora/Redhat systems.  No one remembers which.
     chcon -t unconfined_execmem_exec_t '/usr/bin/VBoxClient' > /dev/null 2>&1
     semanage fcontext -a -t unconfined_execmem_exec_t '/usr/bin/VBoxClient' > /dev/null 2>&1

trunk/src/VBox/Additions/linux/installer/vboxadd.sh

@@ -475 +475 @@
         command -v semanage > /dev/null &&
             semanage fcontext -a -t mount_exec_t "${INSTALL_DIR}/other/mount.vboxsf"
-        chcon -t mount_exec_t "${INSTALL_DIR}/other/mount.vboxsf"
+        chcon -t mount_exec_t "${INSTALL_DIR}/other/mount.vboxsf" 2>/dev/null
     fi
 }
@@ -489 +489 @@
     MODULE_SRC="$INSTALL_DIR/src/vboxguest-$INSTALL_VER"
     BUILDINTMP="$MODULE_SRC/build_in_tmp"
+    # chcon is needed on old Fedora/Redhat systems.  No one remembers which.
     test ! -e /etc/selinux/config ||
-        chcon -t bin_t "$BUILDINTMP"
+        chcon -t bin_t "$BUILDINTMP" 2>/dev/null
 
     if test -z "$INSTALL_NO_MODULE_BUILDS"; then