Changeset 77074 in vbox for trunk/src/VBox

Timestamp:

Jan 31, 2019 1:04:40 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

128524

Message:

Guest Control/Main: Get rid of uProcFlags parameter of GuestProcess::i_waitResultImpliesEx(); not needed there.

Location:

trunk/src/VBox/Main

Files:

• include/GuestProcessImpl.h (modified) (1 diff)
• src-client/GuestProcessImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/include/GuestProcessImpl.h

@@ -75 +75 @@
     static HRESULT i_setErrorExternal(VirtualBoxBase *pInterface, int guestRc);
     static ProcessWaitResult_T i_waitFlagsToResultEx(uint32_t fWaitFlags, ProcessStatus_T oldStatus, ProcessStatus_T newStatus, uint32_t uProcFlags, uint32_t uProtocol);
-    static bool i_waitResultImpliesEx(ProcessWaitResult_T waitResult, ProcessStatus_T procStatus, uint32_t uProcFlags, uint32_t uProtocol);
+    static bool i_waitResultImpliesEx(ProcessWaitResult_T waitResult, ProcessStatus_T procStatus, uint32_t uProtocol);
     /** @}  */
 

trunk/src/VBox/Main/src-client/GuestProcessImpl.cpp

@@ -1641 +1641 @@
 
 /* static */
-bool GuestProcess::i_waitResultImpliesEx(ProcessWaitResult_T waitResult,
-                                         ProcessStatus_T procStatus, uint32_t uProcFlags,
-                                         uint32_t uProtocol)
-{
-    /** @todo r=bird: If you subscribe to HN, which the 'u' in 'uProcFlags'
-     *        indicates, you should actually be using 'fProc'! */
-    RT_NOREF(uProtocol, uProcFlags);
+bool GuestProcess::i_waitResultImpliesEx(ProcessWaitResult_T waitResult, ProcessStatus_T procStatus, uint32_t uProtocol)
+{
+    RT_NOREF(uProtocol);
+
     bool fImplies;