Changeset 77110 in vbox for trunk/src/VBox

Timestamp:

Feb 1, 2019 11:00:12 AM (6 years ago)

Author:

vboxsync

Message:

RTErrConvertFromErrno(): Convert the uNativeCode parameter from unsigned to int. errno is specified to be of type int and while it should only ever contain positive values RTErrConvertFromErrno() is also used inside the various kernel drivers where errno does not exist and the return code might be negative as well. The example here is ERESTART (-1) on FreeBSD causing a compile error with clang and this fix is cleaner IMO instead of casting ERSTART to unsigned.

File:

• trunk/src/VBox/Runtime/common/err/RTErrConvertFromErrno.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/common/err/RTErrConvertFromErrno.cpp

@@ -37 +37 @@
 
 
-RTDECL(int)  RTErrConvertFromErrno(unsigned uNativeCode)
+RTDECL(int)  RTErrConvertFromErrno(int iNativeCode)
 {
     /* very fast check for no error. */
-    if (uNativeCode == 0)
+    if (iNativeCode == 0)
         return VINF_SUCCESS;
 
@@ -52 +52 @@
      * by RTErrConvertToErrno.
      */
-    switch (uNativeCode)
+    switch (iNativeCode)
     {                                                                           /* Linux number */
 #ifdef EPERM