Changeset 77113 in vbox

Timestamp:

Feb 1, 2019 12:51:27 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

128570

Message:

Guest Control/Main: The comment about Guest::i_notifyCtrlDispatcher() is not needed anymore; it's now properly returning error codes.

File:

• trunk/src/VBox/Main/src-client/GuestCtrlImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-client/GuestCtrlImpl.cpp

@@ -65 +65 @@
  *
  * @returns VBox status code.
- *
- * @todo
- *
- * @todo    r=bird: This code mostly returned VINF_SUCCESS with the comment
- *          "Never return any errors back to the guest here." attached to the
- *          return locations.  However, there is no explaination for this attitude
- *          thowards error handling.   Further, it creates a slight problem since
- *          the service would route all message calls it didn't recognize here,
- *          thereby making any undefined messages confusingly return VINF_SUCCESS.
- *
- *          In my humble opinion, if the guest gives us incorrect input it should
- *          expect and deal with error statuses.  If there is unimplemented
- *          features I expect there to have been sufficient forethought by the
- *          coder that these return sensible status codes.
- *
- *          It would be much appreciated if the esteemed card house builder could
- *          please step in and explain this confusing state of affairs.
  */
 /* static */