Changeset 77191 in vbox

Timestamp:

Feb 6, 2019 9:14:23 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

128680

Message:

Main/HGCMThread: Don't clear the thread handle when the thread exits as the thread was created waitable and the handle is required to properly wait on it for termination (first and foremost memory leak fix but who knows, might also fix some HGCM related races where the service thread didn't terminate and the service was already destroyed)

File:

• trunk/src/VBox/Main/src-client/HGCMThread.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-client/HGCMThread.cpp

@@ -202 +202 @@
     pThread->m_fu32ThreadFlags |= HGCMMSG_TF_TERMINATED;
 
-    pThread->m_hThread = NIL_RTTHREAD;
-
     LogFlow(("MAIN::hgcmWorkerThreadFunc: completed HGCM thread %p\n", pThread));
 
@@ -259 +257 @@
 
     if (m_hThread != NIL_RTTHREAD)
+    {
         rc = RTThreadWait(m_hThread, 5000, NULL);
+        m_hThread = NIL_RTTHREAD;
+    }
 
     LogFlowFunc(("rc = %Rrc\n", rc));