VirtualBox

Changeset 77207 in vbox for trunk/src/VBox/Devices


Ignore:
Timestamp:
Feb 7, 2019 10:56:58 PM (6 years ago)
Author:
vboxsync
svn:sync-xref-src-repo-rev:
128710
Message:

DevVGA-SVGA: Review and cleanup of cursor code and more, untested, though should be saner now and less messy stylewise. bugref:9376 [whitespace fix]

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/VBox/Devices/Graphics/DevVGA-SVGA.cpp

    r77206 r77207  
    23852385    AssertPtr(pThis);
    23862386
    2387     /* 
     2387    /*
    23882388     * Wake up the FIFO thread as it might have work to do now.
    23892389     */
    23902390    int rc = SUPSemEventSignal(pThis->svga.pSupDrvSession, pThis->svga.FIFORequestSem);
    23912391    AssertLogRelRC(rc);
    2392    
     2392
    23932393# ifdef DEBUG_FIFO_ACCESS
    2394     /* 
    2395      * When in debug-fifo-access mode, we do not disable the access handler, 
     2394    /*
     2395     * When in debug-fifo-access mode, we do not disable the access handler,
    23962396     * but leave it on as we wish to catch all access.
    23972397     */
     
    23992399    rc = vmsvgaDebugFIFOAccess(pVM, pThis, GCPhys, enmAccessType == PGMACCESSTYPE_WRITE);
    24002400# else
    2401     /* 
     2401    /*
    24022402     * Temporarily disable the access handler now that we've kicked the FIFO thread.
    2403      */ 
     2403     */
    24042404#  ifdef VBOX_STRICT /** @todo r=bird: This is _not_ guaranteed at all.  Expect spurious assertions! */
    24052405    /* Invariant: The access handler should never trigger twice within a certain
    2406        time span; calling it 500ms here for simplicity. */ 
     2406       time span; calling it 500ms here for simplicity. */
    24072407    uint64_t TimeNow = RTTimeMilliTS();
    24082408    Assert(TimeNow - pThis->svga.pSvgaR3State->TimeLastFIFOIntercept > 500);
     
    32363236 * Sends cursor position and visibility information from the FIFO to the front-end.
    32373237 * @returns SVGA_FIFO_CURSOR_COUNT value used.
    3238  */ 
     3238 */
    32393239static uint32_t
    32403240vmsvgaFIFOUpdateCursor(PVGASTATE pVGAState, PVMSVGAR3STATE  pSVGAState, uint32_t RT_UNTRUSTED_VOLATILE_GUEST *pFIFO,
     
    33803380    RTMSINTERVAL        cMsSleep              = cMsMaxSleep;
    33813381
    3382     /* 
     3382    /*
    33833383     * Cursor update state (SVGA_FIFO_CAP_CURSOR_BYPASS_3).
    33843384     * Initialize with values that will trigger an update as soon as maybe.
     
    49904990
    49914991
    4992 /** 
     4992/**
    49934993 * Unsigned coordinates in pBox. Clip to [0; pSizeSrc), [0; pSizeDest).
    49944994 *
     
    50385038}
    50395039
    5040 /** 
     5040/**
    50415041 * Unsigned coordinates in pBox. Clip to [0; pSize).
    50425042 *
     
    50665066}
    50675067
    5068 /** 
     5068/**
    50695069 * Clip.
    50705070 *
Note: See TracChangeset for help on using the changeset viewer.

© 2025 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette