Changeset 77240 in vbox for trunk/src/VBox/VMM/VMMR3

Timestamp:

Feb 10, 2019 4:34:51 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

128747

Message:

PGMPool: Two optimizations to the dirty page code (PGMPOOL_WITH_OPTIMIZED_DIRTY_PT): Inline the first part of pgmPoolIsDirtyPage so we don't waste time on a full fledged call for nested paging. Split the PGMPOOL::aDirtyPages structure into index and page data so we can scan the indexes without requiring a cache line load for each entry. Also eliminated some double uIdx reads and checks.

File:

• trunk/src/VBox/VMM/VMMR3/PGMPool.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMR3/PGMPool.cpp

@@ -743 +743 @@
     for (unsigned i = 0; i < RT_ELEMENTS(pPool->aDirtyPages); i++)
     {
-        PPGMPOOLPAGE pPage;
-        unsigned     idxPage;
-
-        if (pPool->aDirtyPages[i].uIdx == NIL_PGMPOOL_IDX)
+        unsigned idxPage = pPool->aidxDirtyPages[i];
+        if (idxPage == NIL_PGMPOOL_IDX)
             continue;
 
-        idxPage = pPool->aDirtyPages[i].uIdx;
-        AssertRelease(idxPage != NIL_PGMPOOL_IDX);
-        pPage = &pPool->aPages[idxPage];
+        PPGMPOOLPAGE pPage = &pPool->aPages[idxPage];
         Assert(pPage->idx == idxPage);
         Assert(pPage->iMonitoredNext == NIL_PGMPOOL_IDX && pPage->iMonitoredPrev == NIL_PGMPOOL_IDX);
@@ -764 +760 @@
         pPage->fDirty = false;
 
-        pPool->aDirtyPages[i].uIdx = NIL_PGMPOOL_IDX;
+        pPool->aidxDirtyPages[i] = NIL_PGMPOOL_IDX;
     }