Changeset 77240 in vbox for trunk/src/VBox/VMM/include

Timestamp:

Feb 10, 2019 4:34:51 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

128747

Message:

PGMPool: Two optimizations to the dirty page code (PGMPOOL_WITH_OPTIMIZED_DIRTY_PT): Inline the first part of pgmPoolIsDirtyPage so we don't waste time on a full fledged call for nested paging. Split the PGMPOOL::aDirtyPages structure into index and page data so we can scan the indexes without requiring a cache line load for each entry. Also eliminated some double uIdx reads and checks.

Location:

trunk/src/VBox/VMM/include

Files:

• PGMInline.h (modified) (1 diff)
• PGMInternal.h (modified) (2 diffs)

trunk/src/VBox/VMM/include/PGMInline.h

@@ -1496 +1496 @@
 
 /**
+ * Check if the specified page is dirty (not write monitored)
+ *
+ * @return dirty or not
+ * @param   pVM             The cross context VM structure.
+ * @param   GCPhys          Guest physical address
+ */
+DECLINLINE(bool) pgmPoolIsDirtyPage(PVM pVM, RTGCPHYS GCPhys)
+{
+    PPGMPOOL pPool = pVM->pgm.s.CTX_SUFF(pPool);
+    PGM_LOCK_ASSERT_OWNER(pVM);
+    if (!pPool->cDirtyPages)
+        return false;
+    return pgmPoolIsDirtyPageSlow(pVM, GCPhys);
+}
+
+
+/**
  * Tells if mappings are to be put into the shadow page table or not.
  *

trunk/src/VBox/VMM/include/PGMInternal.h

@@ -2476 +2476 @@
     uint32_t                    cDirtyPages;
     /** Array of current dirty pgm pool page indices. */
+    uint16_t                    aidxDirtyPages[16];
+    /** Array running in parallel to aidxDirtyPages with the page data. */
     struct
     {
-        uint16_t                    uIdx;
-        uint16_t                    Alignment[3];
-        uint64_t                    aPage[512];
+        uint64_t                aPage[512];
     } aDirtyPages[16];
+
     /** The number of pages currently in use. */
     uint16_t                    cUsedPages;
@@ -4294 +4295 @@
 PPGMPOOLPAGE    pgmPoolQueryPageForDbg(PPGMPOOL pPool, RTHCPHYS HCPhys);
 int             pgmPoolSyncCR3(PVMCPU pVCpu);
-bool            pgmPoolIsDirtyPage(PVM pVM, RTGCPHYS GCPhys);
+bool            pgmPoolIsDirtyPageSlow(PVM pVM, RTGCPHYS GCPhys);
 void            pgmPoolInvalidateDirtyPage(PVM pVM, RTGCPHYS GCPhysPT);
 int             pgmPoolTrackUpdateGCPhys(PVM pVM, RTGCPHYS GCPhysPage, PPGMPAGE pPhysPage, bool fFlushPTEs, bool *pfFlushTLBs);