Changeset 77265 in vbox for trunk/src/VBox/Additions

Timestamp:

Feb 11, 2019 3:47:23 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

128773

Message:

VBoxClient/vmsvga-x11: test for uname(2) being -1 on failure, not just non-null.
ticketref:18428: VBoxClient --vm-svga fails with "Failed to get kernel name" on Solaris guests
On Linux, uname returns -1 on failure and zero on success. On Solaris it
returns -1 and zero or greater. So testing it to be non-zero is not valid
for detecting failure. This change fixes that.

File:

• trunk/src/VBox/Additions/x11/VBoxClient/display-svga-x11.cpp (modified) (1 diff)

trunk/src/VBox/Additions/x11/VBoxClient/display-svga-x11.cpp

@@ -62 +62 @@
     struct utsname name;
 
-    if (uname(&name))
+    if (uname(&name) == -1)
         VBClFatalError(("Failed to get kernel name.\n"));
     if (strcmp(name.sysname, "Linux"))