Changeset 77313 in vbox

Timestamp:

Feb 14, 2019 3:45:36 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

128840

Message:

FE/Qt: bugref:9241: VirtualBox Manager UI: Simplify Chooser pane selection change handler.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager

Files:

• UIVirtualBoxManagerWidget.cpp (modified) (5 diffs)
• UIVirtualBoxManagerWidget.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualBoxManagerWidget.cpp

@@ -204 +204 @@
 {
     /* Make sure chosen item fetched: */
-    sltHandleChooserPaneIndexChange(false /* update details? */, false /* update snapshots? */, false /* update the logviewer? */);
+    sltHandleChooserPaneIndexChange();
 
 #ifdef VBOX_WS_MAC
@@ -216 +216 @@
 }
 
-void UIVirtualBoxManagerWidget::sltHandleChooserPaneIndexChange(bool fUpdateDetails /* = true */,
-                                                                bool fUpdateSnapshots /* = true */,
-                                                                bool fUpdateLogs /* = true */)
+void UIVirtualBoxManagerWidget::sltHandleChooserPaneIndexChange()
 {
     /* Let the parent know: */
@@ -267 +265 @@
                 sltHandleToolsPaneIndexChange();
 
-            /* Propagate current items to update the Details-pane (if requested): */
-            if (fUpdateDetails)
-                m_pPaneToolsMachine->setItems(currentItems());
-            /* Propagate current machine to update the Snapshots-pane or/and Logviewer-pane (if requested): */
-            if (fUpdateSnapshots || fUpdateLogs)
-                m_pPaneToolsMachine->setMachine(pItem->machine());
+            /* Propagate current items to update the Details-pane: */
+            m_pPaneToolsMachine->setItems(currentItems());
+            /* Propagate current machine to update the Snapshots-pane or/and Logviewer-pane: */
+            m_pPaneToolsMachine->setMachine(pItem->machine());
         }
         else
@@ -310 +306 @@
     }
     /* Then handle current item change (again!): */
-    sltHandleChooserPaneIndexChangeDefault();
+    sltHandleChooserPaneIndexChange();
 }
 
@@ -529 +525 @@
     /* Chooser-pane connections: */
     connect(m_pPaneChooser, &UIChooser::sigSelectionChanged,
-            this, &UIVirtualBoxManagerWidget::sltHandleChooserPaneIndexChangeDefault);
+            this, &UIVirtualBoxManagerWidget::sltHandleChooserPaneIndexChange);
     connect(m_pPaneChooser, &UIChooser::sigSlidingStarted,
             m_pPaneToolsMachine, &UIToolPaneMachine::sigSlidingStarted);

trunk/src/VBox/Frontends/VirtualBox/src/manager/UIVirtualBoxManagerWidget.h

@@ -145 +145 @@
     /** @name Common stuff.
       * @{ */
-        /** Handles signal about Chooser-pane index change.
-          * @param  fUpdateDetails    Brings whether details should be updated.
-          * @param  fUpdateSnapshots  Brings whether snapshots should be updated.
-          * @param  fUpdateLogs       Brings whether log-viewer should be updated. */
-        void sltHandleChooserPaneIndexChange(bool fUpdateDetails = true,
-                                             bool fUpdateSnapshots = true,
-                                             bool fUpdateLogs = true);
-        /** Handles signal about Chooser-pane index change the default way. */
-        void sltHandleChooserPaneIndexChangeDefault() { sltHandleChooserPaneIndexChange(); }
+        /** Handles signal about Chooser-pane index change. */
+        void sltHandleChooserPaneIndexChange();
 
         /** Handles sliding animation complete signal.