Changeset 77344 in vbox

Timestamp:

Feb 18, 2019 10:58:26 AM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

128881

Message:

FE/Qt: bugref:9340. Fixes to r128874.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/VBoxGlobal.cpp (modified) (3 diffs)
• medium/UIFDCreationDialog.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/globals/VBoxGlobal.cpp

@@ -2835 +2835 @@
 }
 
-QUuid VBoxGlobal::createHDWithNewHDWizard(QWidget *pParent, const QString &strMachineGuestOSTypeId  /* = QString() */,
-                                          const QString &strMachineFolder /* = QString() */,
-                                          const QString &strMachineName /* = QString() */)
+QUuid VBoxGlobal::createHDWithNewHDWizard(QWidget *pParent,  const QString &strMachineFolder /* = QString() */,
+                                          const QString &strMachineName /* = QString() */,
+                                          const QString &strMachineGuestOSTypeId  /* = QString() */)
 {
     /* Initialize variables: */
@@ -2887 +2887 @@
     pActionOpenExistingMedium->setData(QVariant::fromValue(UIMediumTarget(strControllerName, comCurrentAttachment.GetPort(),
                                                                           comCurrentAttachment.GetDevice(), enmMediumType)));
-    pActionOpenExistingMedium->setText(QApplication::translate("UIMachineSettingsStorage", "Choose disk image...",
+    pActionOpenExistingMedium->setText(QApplication::translate("UIMachineSettingsStorage", "Choose/Create a disk image...",
                                                                "This is used for hard disks, optical media and floppies"));
 
-    /* Prepare create floppy disk action: */
-    if (enmMediumType == UIMediumDeviceType_Floppy)
-    {
-        QAction *pActionCreateFloppy = menu.addAction(UIIconPool::iconSet(":/fd_add_16px.png"),
-                                                      QString(), pListener, pszSlotName);
-        pActionCreateFloppy->setData(QVariant::fromValue(UIMediumTarget(strControllerName, comCurrentAttachment.GetPort(),
-                                                                        comCurrentAttachment.GetDevice(), enmMediumType,
-                                                                        UIMediumTarget::UIMediumTargetType_CreateFloppyDisk)));
-        pActionCreateFloppy->setText(QApplication::translate("UIMachineSettingsStorage", "Create a new floppy disk...",
-                                                             "This is used to create a new floppy disk"));
-    }
-    /* Prepare ad-hoc-viso action for DVD-ROMs: */
-    if (enmMediumType == UIMediumDeviceType_DVD)
-    {
-        QAction *pActionAdHocViso = menu.addAction(UIIconPool::iconSet(":/select_file_16px.png"),
-                                                   QString(), pListener, pszSlotName);
-        pActionAdHocViso->setData(QVariant::fromValue(UIMediumTarget(strControllerName, comCurrentAttachment.GetPort(),
-                                                                     comCurrentAttachment.GetDevice(), enmMediumType,
-                                                                     UIMediumTarget::UIMediumTargetType_CreateAdHocVISO)));
-        pActionAdHocViso->setText(QApplication::translate("UIMachineSettingsStorage", "Create ad hoc VISO...",
-                                                          "This is used for optical media"));
-    }
+    // /* Prepare create floppy disk action: */
+    // if (enmMediumType == UIMediumDeviceType_Floppy)
+    // {
+    //     QAction *pActionCreateFloppy = menu.addAction(UIIconPool::iconSet(":/fd_add_16px.png"),
+    //                                                   QString(), pListener, pszSlotName);
+    //     pActionCreateFloppy->setData(QVariant::fromValue(UIMediumTarget(strControllerName, comCurrentAttachment.GetPort(),
+    //                                                                     comCurrentAttachment.GetDevice(), enmMediumType,
+    //                                                                     UIMediumTarget::UIMediumTargetType_CreateFloppyDisk)));
+    //     pActionCreateFloppy->setText(QApplication::translate("UIMachineSettingsStorage", "Create a new floppy disk...",
+    //                                                          "This is used to create a new floppy disk"));
+    // }
+    // /* Prepare ad-hoc-viso action for DVD-ROMs: */
+    // if (enmMediumType == UIMediumDeviceType_DVD)
+    // {
+    //     QAction *pActionAdHocViso = menu.addAction(UIIconPool::iconSet(":/select_file_16px.png"),
+    //                                                QString(), pListener, pszSlotName);
+    //     pActionAdHocViso->setData(QVariant::fromValue(UIMediumTarget(strControllerName, comCurrentAttachment.GetPort(),
+    //                                                                  comCurrentAttachment.GetDevice(), enmMediumType,
+    //                                                                  UIMediumTarget::UIMediumTargetType_CreateAdHocVISO)));
+    //     pActionAdHocViso->setText(QApplication::translate("UIMachineSettingsStorage", "Create ad hoc VISO...",
+    //                                                       "This is used for optical media"));
+    // }
 
 
@@ -3076 +3076 @@
                 {
                     int iDialogReturn = openMediumSelectorDialog(windowManager().mainWindowShown(), target.mediumType, uMediumID,
-                                                                 strMachineFolder, "" /*strMachineName*/,
-                                                                 "" /*strMachineGuestOSTypeId*/, true /*fEnableCreate */);
+                                                                 strMachineFolder, comConstMachine.GetName(),
+                                                                 comConstMachine.GetOSTypeId(), true /*fEnableCreate */);
                     if (iDialogReturn == UIMediumSelector::ReturnCode_LeftEmpty &&
                         (target.mediumType == UIMediumDeviceType_DVD || target.mediumType == UIMediumDeviceType_Floppy))

trunk/src/VBox/Frontends/VirtualBox/src/medium/UIFDCreationDialog.cpp

@@ -167 +167 @@
 
     QString strDiskname = !(m_strMachineName.isEmpty()) ? m_strMachineName : "NewFloppyDisk";
-    strDiskname = VBoxGlobal::findUniqueFileName(m_strDefaultFolder, m_strMachineName);
+    strDiskname = VBoxGlobal::findUniqueFileName(m_strDefaultFolder, strDiskname);
 
     strInitialPath = QDir(strInitialPath).absoluteFilePath(strDiskname + "." + strPreferredExtension);