Changeset 77368 in vbox for trunk/src/VBox/ValidationKit/tests

Timestamp:

Feb 19, 2019 5:32:22 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

128910

Message:

Guest Control/Validation Kit: More fixes for Windows XP SP2 guests.

File:

• trunk/src/VBox/ValidationKit/tests/additions/tdAddGuestCtrl.py (modified) (9 diffs)

trunk/src/VBox/ValidationKit/tests/additions/tdAddGuestCtrl.py

@@ -2615 +2615 @@
             ]);
 
-            if oTestVm.sVmName == "tst-xppro":
-                aaTests.extend([
-                    # Reading directories.
-                    [ tdTestDirRead(sUser = sUser, sPassword = sPassword, sDirectory = '../../Windows/Media'),
-                      tdTestResultDirRead(fRc = True, numFiles = 36) ],
-                    [ tdTestDirRead(sUser = sUser, sPassword = sPassword, sDirectory = 'c:\\Windows\\Help'),
-                      tdTestResultDirRead(fRc = True, numDirs = 13, numFiles = 569) ],
-                    [ tdTestDirRead(sUser = sUser, sPassword = sPassword, sDirectory = 'c:\\Windows\\Web'),
-                      tdTestResultDirRead(fRc = True, numDirs = 3, numFiles = 55) ]
-                ]);
-
-            if oTestVm.sVmName == "tst-xpsp2":
+            if oTestVm.sVmName.startswith('tst-xpsp2'):
                 aaTests.extend([
                     # Reading directories.
@@ -2822 +2811 @@
 
         # Some test VM specific tests.
-        if oTestVm.sVmName == 'tst-xppro':
-            aoTests += [ tdTestSessionEx([ tdStepStatFileSize('c:\\Windows\\system32\\kernel32.dll', 926720), ]) ];
+        if oTestVm.sVmName.startswith('tst-xpsp2'):
+            aoTests += [ tdTestSessionEx([ tdStepStatFileSize('c:\\Windows\\system32\\kernel32.dll', 983552), ]) ];
 
         #
@@ -2902 +2891 @@
             ]);
 
-        if oTestVm.sKind == "WindowsXP":
-            aaTests.extend([
-                # Reading from beginning.
-                [ tdTestFileReadWrite(sUser = sUser, sPassword = sPassword, sFile = 'C:\\Windows\\System32\\eula.txt', \
-                                      sOpenMode = 'r', sDisposition = 'oe', cbToReadWrite = 33),
-                  tdTestResultFileReadWrite(fRc = True, aBuf = 'Microsoft Windows XP Professional', \
-                                            cbProcessed = 33, cbOffset = 33) ],
-                # Reading from offset.
-                [ tdTestFileReadWrite(sUser = sUser, sPassword = sPassword, sFile = 'C:\\Windows\\System32\\eula.txt', \
-                                      sOpenMode = 'r', sDisposition = 'oe', cbOffset = 17782, cbToReadWrite = 26),
-                  tdTestResultFileReadWrite(fRc = True, aBuf = 'LINKS TO THIRD PARTY SITES', \
-                                            cbProcessed = 26, cbOffset = 17782 + 26) ]
-            ]);
+            # Note: tst-xppro has other contents in eula.txt.
+            if oTestVm.sVmName.startswith('tst-xpsp2'):
+                aaTests.extend([
+                    # Reading from beginning.
+                    [ tdTestFileReadWrite(sUser = sUser, sPassword = sPassword, sFile = 'C:\\Windows\\System32\\eula.txt',
+                                        sOpenMode = 'r', sDisposition = 'oe', cbToReadWrite = 33),
+                      tdTestResultFileReadWrite(fRc = True, aBuf = 'Microsoft(r) Windows(r) XP Profes',
+                                                cbProcessed = 33, cbOffset = 33) ],
+                    # Reading from offset.
+                    [ tdTestFileReadWrite(sUser = sUser, sPassword = sPassword, sFile = 'C:\\Windows\\System32\\eula.txt',
+                                        sOpenMode = 'r', sDisposition = 'oe', cbOffset = 17769, cbToReadWrite = 31),
+                      tdTestResultFileReadWrite(fRc = True, aBuf = 'only with the HARDWARE. If\x0d\x0a   ',
+                                                cbProcessed = 31, cbOffset = 17769 + 31) ]
+                ]);
 
         fRc = True;
@@ -2928 +2918 @@
                 break;
             try:
+                fRc2 = True;
                 if curTest.cbOffset > 0: # The offset parameter is gone.
                     if self.oTstDrv.fpApiVer >= 5.0:
@@ -2941 +2932 @@
                         reporter.error('Test #%d failed: Initial offset on open does not match: Got %d, expected %d' \
                                        % (i, curOffset, resOffset));
-                        fRc = False;
+                        fRc2 = False;
                 else:
                     if self.oTstDrv.fpApiVer >= 5.0:
@@ -2949 +2940 @@
                         curFile = curGuestSession.fileOpen(curTest.sFile, curTest.sOpenMode, curTest.sDisposition, \
                                                            curTest.lCreationMode);
-                if  fRc \
+                if  fRc2 \
                 and curTest.cbToReadWrite > 0:
                     ## @todo Split this up in 64K reads. Later.
@@ -2958 +2949 @@
                         reporter.error('Test #%d failed: Read buffer length does not match: Got %d, expected %d' \
                                        % (i, len(aBufRead), curRes.cbProcessed));
-                        fRc = False;
-                    if fRc:
+                        fRc2 = False;
+                    if fRc2:
                         if  curRes.aBuf is not None \
                         and bytes(curRes.aBuf) != bytes(aBufRead):
-                            reporter.error('Test #%d failed: Got buffer\n%s (%d bytes), expected\n%s (%d bytes)' \
-                                           % (i, map(hex, map(ord, aBufRead)), len(aBufRead), \
+                            reporter.error('Test #%d failed: Got buffer:\n"%s" (%d bytes)\nExpected buffer:\n"%s" (%d bytes)' \
+                                           % (i, map(hex, map(ord, aBufRead)), len(aBufRead),
                                               map(hex, map(ord, curRes.aBuf)), len(curRes.aBuf)));
-                            reporter.error('Test #%d failed: Got buffer\n%s, expected\n%s' \
+                            reporter.error('Test #%d failed: Got buffer:\n"%s"\nExpected buffer:\n"%s"' \
                                            % (i, aBufRead, curRes.aBuf));
-                            fRc = False;
+                            fRc2 = False;
                 # Test final offset.
                 curOffset = long(curFile.offset);
@@ -2974 +2965 @@
                     reporter.error('Test #%d failed: Final offset does not match: Got %d, expected %d' \
                                    % (i, curOffset, resOffset));
+                    fRc2 = False;
+                curFile.close();
+
+                if fRc2 != curRes.fRc:
+                    reporter.error('Test #%d failed: Got %s, expected %s' % (i, fRc2, curRes.fRc));
                     fRc = False;
-                curFile.close();
+
             except:
                 reporter.logXcpt('Opening "%s" failed:' % (curTest.sFile,));
@@ -2981 +2977 @@
 
             curTest.closeSession();
-
-            if fRc != curRes.fRc:
-                reporter.error('Test #%d failed: Got %s, expected %s' % (i, fRc, curRes.fRc));
-                fRc = False;
-                break;
 
         return (fRc, oTxsSession);