Changeset 77472 in vbox

Timestamp:

Feb 26, 2019 3:55:06 PM (6 years ago)

Author:

vboxsync

Message:

Validation Kit/testdriver: Fixed downloading guest files via txsService -- do the temporary file truncation before the download, not after.

File:

• trunk/src/VBox/ValidationKit/testdriver/vbox.py (modified) (2 diffs)

trunk/src/VBox/ValidationKit/testdriver/vbox.py

@@ -3293 +3293 @@
         fRc = True;
         for sGstFile in asFiles:
+            sTmpFile = os.path.join(self.sScratchPath, 'tmp-' + os.path.basename(sGstFile));
+            reporter.log2('Downloading file "%s" to "%s" ...' % (sGstFile, sTmpFile));
             # First try to remove (unlink) an existing temporary file, as we don't truncate the file.
             try:    os.unlink(sTmpFile);
@@ -3298 +3300 @@
             ## @todo Check for already existing files on the host and create a new
             #        name for the current file to download.
-            sTmpFile = os.path.join(self.sScratchPath, 'tmp-' + os.path.basename(sGstFile));
-            reporter.log2('Downloading file "%s" to "%s" ...' % (sGstFile, sTmpFile));
             fRc = self.txsDownloadFile(oSession, oTxsSession, sGstFile, sTmpFile, 30 * 1000, fIgnoreErrors);
             if fRc: