Changeset 77624 in vbox for trunk/src/VBox/Main/src-all

Timestamp:

Mar 8, 2019 5:33:50 PM (6 years ago)

Author:

vboxsync

Message:

Main/ExtPackManager: fix leak of CloudProviderManager instance from an extpack

File:

• trunk/src/VBox/Main/src-all/ExtPackManagerImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-all/ExtPackManagerImpl.cpp

@@ -2090 +2090 @@
     CheckComArgGuid(aObjUuid, ObjectId);
 
-    HRESULT hrc  S_OK;
+    HRESULT hrc = S_OK;
 
     if (   m->pReg
@@ -2097 +2097 @@
         void *pvUnknown = m->pReg->pfnQueryObject(m->pReg, ObjectId.raw());
         if (pvUnknown)
-             aReturnInterface = (IUnknown *)pvUnknown;
+        {
+            aReturnInterface = (IUnknown *)pvUnknown;
+            /* The above assignment increased the refcount. Since pvUnknown
+             * is a dumb pointer we have to do the release ourselves. */
+            ((IUnknown *)pvUnknown)->Release();
+        }
         else
             hrc = E_NOINTERFACE;