Changeset 77653 in vbox

Timestamp:

Mar 11, 2019 2:03:37 PM (6 years ago)

Author:

vboxsync

Message:

vsheriff: Limit check for hanging testboxes to cHoursBack and testboxes which actually existing currently (which will avoid looking at testboxes which are gone for good years ago or are hanging for a while now), which avoids running into errors which prevent re-running the bad testbox checks at the end of the analysis run. This should finally make it work since the new failure rate is rather high and therefore there are usually too many non-categorized failures to make a decision. Also consider driver load failures as a sign of a bad testbox.

File:

• trunk/src/VBox/ValidationKit/testmanager/batch/virtual_test_sheriff.py (modified) (3 diffs)

trunk/src/VBox/ValidationKit/testmanager/batch/virtual_test_sheriff.py

@@ -427 +427 @@
         #
         aidFailureReasons = [
+            self.getFailureReason(self.ktReason_Host_DriverNotLoaded).idFailureReason,
             self.getFailureReason(self.ktReason_Host_DriverNotUnloading).idFailureReason,
             self.getFailureReason(self.ktReason_Host_DriverNotCompilable).idFailureReason,
@@ -513 +514 @@
         cStatusTimeoutMins = 10;
 
-        self.oDb.execute('SELECT idTestBox FROM TestBoxStatuses WHERE tsUpdated < (CURRENT_TIMESTAMP - interval \'%s minutes\')', (cStatusTimeoutMins,));
+        self.oDb.execute('SELECT TestBoxStatuses.idTestBox\n'
+                         '  FROM TestBoxStatuses, TestBoxes\n'
+                         ' WHERE TestBoxStatuses.tsUpdated >= (CURRENT_TIMESTAMP - interval \'%s hours\')\n'
+                         '   AND TestBoxStatuses.tsUpdated < (CURRENT_TIMESTAMP - interval \'%s minutes\')\n'
+                         '   AND TestBoxStatuses.idTestBox = TestBoxes.idTestBox\n'
+                         '   AND Testboxes.tsExpire = \'infinity\'::timestamp', (cHoursBack,cStatusTimeoutMins));
         for idTestBox in self.oDb.fetchAll():
             idTestBox = idTestBox[0];
@@ -541 +547 @@
 
             except Exception as oXcpt:
-                rcExit = self.eprint(u'Error reseting testbox #%u (%s): %s\n' % (idTestBox, oTestBox.sName, oXcpt,));
+                rcExit = self.eprint(u'Error resetting testbox #%u (%s): %s\n' % (idTestBox, oTestBox.sName, oXcpt,));
 
         return rcExit;