Changeset 77654 in vbox for trunk/src/VBox

Timestamp:

Mar 11, 2019 2:40:11 PM (6 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9241: VirtualBox Manager UI: Chooser pane: Properly update parent item's geometry when it's child being deleted; for that, child have to be removed from the layout prematurely not from internal list only.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserItemGroup.cpp (modified) (4 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserItemGroup.cpp

@@ -434 +434 @@
             AssertMsg(m_globalItems.contains(pItem), ("Global-item was not found!"));
             m_globalItems.removeAt(m_globalItems.indexOf(pItem));
+            if (pItem->isFavorite())
+                m_pLayoutFavorite->removeItem(pItem);
+            else
+                m_pLayoutGlobal->removeItem(pItem);
             break;
         }
@@ -440 +444 @@
             AssertMsg(m_groupItems.contains(pItem), ("Group-item was not found!"));
             m_groupItems.removeAt(m_groupItems.indexOf(pItem));
+            if (pItem->isFavorite())
+                m_pLayoutFavorite->removeItem(pItem);
+            else
+                m_pLayoutGroup->removeItem(pItem);
             break;
         }
@@ -446 +454 @@
             AssertMsg(m_machineItems.contains(pItem), ("Machine-item was not found!"));
             m_machineItems.removeAt(m_machineItems.indexOf(pItem));
+            if (pItem->isFavorite())
+                m_pLayoutFavorite->removeItem(pItem);
+            else
+                m_pLayoutMachine->removeItem(pItem);
             break;
         }
@@ -537 +549 @@
 void UIChooserItemGroup::updateGeometry()
 {
-    /* Call to base-class: */
-    UIChooserItem::updateGeometry();
-
     /* Update/activate children layout: */
     m_pLayout->updateGeometry();
     m_pLayout->activate();
+
+    /* Call to base-class: */
+    UIChooserItem::updateGeometry();
 }