Changeset 77722 in vbox

Timestamp:

Mar 15, 2019 11:37:18 AM (6 years ago)

Author:

vboxsync

Message:

Drivers/Linux: add missing init and exit markers.
bugref:4567: Linux kernel driver maintenance.
Building against linux-next, we get some ugly warnings in vboxpci, vboxnetflt
and vboxnetadp (...)
Fortunately, the fix is simple - match the forward definition:s attributes to
the target attributes. I am not sure why vboxdrv does not throw a warning, but
we will swat it there as well while we are at it.
Michael: do VBoxGuest as well.
Thank you Valdis Klētnieks for the patch.

Location:

trunk/src/VBox

Files:

• Additions/common/VBoxGuest/VBoxGuest-linux.c (modified) (1 diff)
• HostDrivers/Support/linux/SUPDrv-linux.c (modified) (1 diff)
• HostDrivers/VBoxNetAdp/linux/VBoxNetAdp-linux.c (modified) (1 diff)
• HostDrivers/VBoxNetFlt/linux/VBoxNetFlt-linux.c (modified) (1 diff)
• HostDrivers/VBoxPci/linux/VBoxPci-linux.c (modified) (1 diff)

trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuest-linux.c

@@ -101 +101 @@
 static void vgdrvLinuxTermPci(struct pci_dev *pPciDev);
 static int  vgdrvLinuxProbePci(struct pci_dev *pPciDev, const struct pci_device_id *id);
-static int  vgdrvLinuxModInit(void);
-static void vgdrvLinuxModExit(void);
+static int  __init vgdrvLinuxModInit(void);
+static void __exit vgdrvLinuxModExit(void);
 static int  vgdrvLinuxOpen(struct inode *pInode, struct file *pFilp);
 static int  vgdrvLinuxRelease(struct inode *pInode, struct file *pFilp);

trunk/src/VBox/HostDrivers/Support/linux/SUPDrv-linux.c

@@ -98 +98 @@
 *   Internal Functions                                                                                                           *
 *********************************************************************************************************************************/
-static int  VBoxDrvLinuxInit(void);
-static void VBoxDrvLinuxUnload(void);
+static int  __init VBoxDrvLinuxInit(void);
+static void __exit VBoxDrvLinuxUnload(void);
 static int  VBoxDrvLinuxCreateSys(struct inode *pInode, struct file *pFilp);
 static int  VBoxDrvLinuxCreateUsr(struct inode *pInode, struct file *pFilp);

trunk/src/VBox/HostDrivers/VBoxNetAdp/linux/VBoxNetAdp-linux.c

@@ -71 +71 @@
 *   Internal Functions                                                                                                           *
 *********************************************************************************************************************************/
-static int  VBoxNetAdpLinuxInit(void);
-static void VBoxNetAdpLinuxUnload(void);
+static int  __init VBoxNetAdpLinuxInit(void);
+static void __exit VBoxNetAdpLinuxUnload(void);
 
 static int VBoxNetAdpLinuxOpen(struct inode *pInode, struct file *pFilp);

trunk/src/VBox/HostDrivers/VBoxNetFlt/linux/VBoxNetFlt-linux.c

@@ -216 +216 @@
 *   Internal Functions                                                                                                           *
 *********************************************************************************************************************************/
-static int      VBoxNetFltLinuxInit(void);
-static void     VBoxNetFltLinuxUnload(void);
+static int      __init VBoxNetFltLinuxInit(void);
+static void     __exit VBoxNetFltLinuxUnload(void);
 static void     vboxNetFltLinuxForwardToIntNet(PVBOXNETFLTINS pThis, struct sk_buff *pBuf);
 

trunk/src/VBox/HostDrivers/VBoxPci/linux/VBoxPci-linux.c

@@ -67 +67 @@
 *   Internal Functions                                                                                                           *
 *********************************************************************************************************************************/
-static int  VBoxPciLinuxInit(void);
-static void VBoxPciLinuxUnload(void);
+static int  __init VBoxPciLinuxInit(void);
+static void __exit VBoxPciLinuxUnload(void);