Changeset 77727 in vbox for trunk/src/VBox/HostDrivers

Timestamp:

Mar 15, 2019 2:14:18 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

129375

Message:

IPRT,HostDrivers: Fixed some warnings.

Location:

trunk/src/VBox/HostDrivers

Files:

• Support/SUPDrv.cpp (modified) (1 diff)
• Support/SUPDrvGip.cpp (modified) (5 diffs)
• VBoxNetAdp/linux/VBoxNetAdp-linux.c (modified) (1 diff)
• VBoxPci/VBoxPci.c (modified) (7 diffs)

trunk/src/VBox/HostDrivers/Support/SUPDrv.cpp

@@ -4487 +4487 @@
  * @param   puRevision      Where to store the microcode revision.
  */
-int VBOXCALL supdrvQueryUcodeRev(uint32_t *puRevision)
+static int VBOXCALL supdrvQueryUcodeRev(uint32_t *puRevision)
 {
     int  rc = VERR_UNSUPPORTED_CPU;

trunk/src/VBox/HostDrivers/Support/SUPDrvGip.cpp

@@ -1013 +1013 @@
  *      the measurements on.}
  */
-DECLCALLBACK(void) supdrvGipInitReadTscAndNanoTsOnCpu(RTCPUID idCpu, void *pvUser1, void *pvUser2)
+static DECLCALLBACK(void) supdrvGipInitReadTscAndNanoTsOnCpu(RTCPUID idCpu, void *pvUser1, void *pvUser2)
 {
     RTCCUINTREG fEFlags   = ASMIntDisableFlags();
@@ -3419 +3419 @@
             {
                 /* Read, kick & wait #1. */
-                uint64_t register uTsc = ASMReadTSC();
+                uint64_t uTsc = ASMReadTSC();
                 ASMAtomicWriteU32(&pOtherSync->uSyncVar, GIP_TSC_DELTA_SYNC2_GO_GO);
                 ASMSerializeInstruction();
@@ -3510 +3510 @@
             for (i = 0; i < RT_ELEMENTS(pArgs->uWorker.Verify.auTscs); i += 2)
             {
-                uint64_t register uTsc;
+                uint64_t uTsc;
 
                 /* Wait, Read and Kick #1. */
@@ -4173 +4173 @@
 {
     PSUPDRVDEVEXT     pDevExt = (PSUPDRVDEVEXT)pvUser;
-    uint32_t          cConsecutiveTimeouts = 0;
     int               rc = VERR_INTERNAL_ERROR_2;
     for (;;)
@@ -4225 +4224 @@
             case kTscDeltaThreadState_Measuring:
             {
-                cConsecutiveTimeouts = 0;
                 if (pDevExt->fTscThreadRecomputeAllDeltas)
                 {

trunk/src/VBox/HostDrivers/VBoxNetAdp/linux/VBoxNetAdp-linux.c

@@ -183 +183 @@
 }
 
-struct net_device_stats *vboxNetAdpLinuxGetStats(struct net_device *pNetDev)
+static struct net_device_stats *vboxNetAdpLinuxGetStats(struct net_device *pNetDev)
 {
     PVBOXNETADPPRIV pPriv = netdev_priv(pNetDev);

trunk/src/VBox/HostDrivers/VBoxPci/VBoxPci.c

@@ -160 +160 @@
 
 
+#if 0 /** @todo r=bird: Who the heck is supposed to call this?!?   */
 DECLHIDDEN(void) vboxPciDevCleanup(PVBOXRAWPCIINS pThis)
 {
@@ -180 +181 @@
     vboxPciGlobalsUnlock(pThis->pGlobals);
 }
+#endif
 
 
@@ -674 +676 @@
 }
 
+
 /**
  * Try to close the IDC connection to SUPDRV if established.
@@ -683 +686 @@
  * @param   pGlobals        Pointer to the globals.
  */
-DECLHIDDEN(int) vboxPciDeleteIdc(PVBOXRAWPCIGLOBALS pGlobals)
+static int vboxPciDeleteIdc(PVBOXRAWPCIGLOBALS pGlobals)
 {
     int rc;
@@ -718 +721 @@
  * @param   pGlobals        Pointer to the globals.
  */
-DECLHIDDEN(int) vboxPciInitGlobals(PVBOXRAWPCIGLOBALS pGlobals)
+static int vboxPciInitGlobals(PVBOXRAWPCIGLOBALS pGlobals)
 {
     /*
@@ -742 +745 @@
  * Deletes the globals.
  *
- *
  * @param   pGlobals        Pointer to the globals.
  */
-DECLHIDDEN(void) vboxPciDeleteGlobals(PVBOXRAWPCIGLOBALS pGlobals)
+static void vboxPciDeleteGlobals(PVBOXRAWPCIGLOBALS pGlobals)
 {
     Assert(!pGlobals->fIDCOpen);
@@ -783 +785 @@
 {
     int rc = vboxPciDeleteIdc(pGlobals);
-
     if (RT_SUCCESS(rc))
         vboxPciDeleteGlobals(pGlobals);