Changeset 77756 in vbox for trunk

Timestamp:

Mar 18, 2019 12:47:30 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

129417

Message:

FE/Qt: bugref:9241: VirtualBox Manager: Chooser pane: Adding more clarity for UIChooserItem::makeSureItemIsVisible API.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser

Files:

• UIChooserItem.cpp (modified) (1 diff)
• UIChooserItem.h (modified) (1 diff)
• UIChooserItemGroup.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserItem.cpp

@@ -476 +476 @@
             pParentItem->open(false);
     }
-    /* Make sure we scroll to the item's rectangle: */
-    pParentItem->makeSureItemIsVisible(this);
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserItem.h

@@ -200 +200 @@
         /** Makes sure item is visible. */
         virtual void makeSureItsVisible();
-        /** Makes sure passed child @a pItem is visible. */
+        /** Makes sure passed @a pItem is visible within the current root item.
+          * @note Please keep in mind that any group item can be a root, but there
+          * is just one model root item at the same time, accessible via model's
+          * root() getter, and this API can be called for current root item only,
+          * because this is root item who performs actual scrolling, while
+          * @a pItem itself can be on any level of embedding. */
         virtual void makeSureItemIsVisible(UIChooserItem *pItem) { Q_UNUSED(pItem); }
 

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserItemGroup.cpp

@@ -259 +259 @@
 
     /* Make sure item visible: */
-    AssertPtrReturnVoid(parentItem());
-    parentItem()->toGroupItem()->makeSureItemIsVisible(this);
+    if (model()->root())
+        model()->root()->makeSureItemIsVisible(this);
 
     /* Assign name-editor text: */