Changeset 77772 in vbox

Timestamp:

Mar 18, 2019 9:59:40 PM (6 years ago)

Author:

vboxsync

Message:

vfschain.cpp: Call memcpy only when there is something to copy to avoid ASAN runtime warnings (the spec says that passing NULL pointers is undefined even though most memcpy implementations shouldn't bother as long as the n argument is 0 as well)

File:

• trunk/src/VBox/Runtime/common/vfs/vfschain.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/common/vfs/vfschain.cpp

@@ -531 +531 @@
         }
 
-        memcpy(paNew, pSpec->paElements, iElement * sizeof(paNew[0]));
+        if (iElement)
+            memcpy(paNew, pSpec->paElements, iElement * sizeof(paNew[0]));
         RTMemTmpFree(pSpec->paElements);
         pSpec->paElements = paNew;
@@ -572 +573 @@
         if (!paNew)
             return VERR_NO_TMP_MEMORY;
-        memcpy(paNew, pElement->paArgs, iArg * sizeof(paNew[0]));
+        if (iArg)
+            memcpy(paNew, pElement->paArgs, iArg * sizeof(paNew[0]));
         RTMemTmpFree(pElement->paArgs);
         pElement->paArgs = paNew;