Changeset 77860 in vbox for trunk/src/VBox

Timestamp:

Mar 24, 2019 2:38:22 AM (6 years ago)

Author:

vboxsync

Message:

SharedFoldersSvc: Must convert all kinds of slashes in the symlink target when reading it. And When creating a symlink, we must always stat on the link to get the object info we return to the caller. bugref:9172

File:

• trunk/src/VBox/HostServices/SharedFolders/vbsf.cpp (modified) (2 diffs)

trunk/src/VBox/HostServices/SharedFolders/vbsf.cpp

@@ -1703 +1703 @@
         {
             /* Convert the slashes in the link target to the guest path separator characters. */
+            /** @todo r=bird: for some messed up reason, we return UTF-8 here rather than
+             * the character set selected by the client.  We also don't return the
+             * length, so the clients are paranoid about the zero termination behavior. */
+            char ch;
             char *psz = (char *)pBuffer;
-            while (*psz != '\0')
-            {
-                if (*psz == RTPATH_DELIMITER)
+            while ((ch = *psz) != '\0')
+            {
+                if (RTPATH_IS_SLASH(ch))
                     *psz = pClient->PathDelimiter;
                 psz++;
@@ -2384 +2388 @@
     {
         RTFSOBJINFO info;
-        rc = RTPathQueryInfoEx(pszFullNewPath, &info, RTFSOBJATTRADD_NOTHING, SHFL_RT_LINK(pClient));
+        rc = RTPathQueryInfoEx(pszFullNewPath, &info, RTFSOBJATTRADD_NOTHING, RTPATH_F_ON_LINK);
         if (RT_SUCCESS(rc))
             vbfsCopyFsObjInfoFromIprt(pInfo, &info);