Changeset 78021 in vbox for trunk/src/VBox/GuestHost/DragAndDrop

Timestamp:

Apr 5, 2019 8:25:19 AM (6 years ago)

Author:

vboxsync

Message:

DnD/DnDURIList: Fixed having an invalid (file) handles when opening URI objects without DNDURILIST_FLAGS_KEEP_OPEN being set.

File:

• trunk/src/VBox/GuestHost/DragAndDrop/DnDURIList.cpp (modified) (2 diffs)

trunk/src/VBox/GuestHost/DragAndDrop/DnDURIList.cpp

@@ -65 +65 @@
             if (pObjFile)
             {
-                if (fFlags & DNDURILIST_FLAGS_KEEP_OPEN) /* Shall we keep the file open while being added to this list? */
-                {
-                    /** @todo Add a standard fOpen mode for this list. */
-                    rc = pObjFile->Open(DnDURIObject::View_Source, RTFILE_O_OPEN | RTFILE_O_READ | RTFILE_O_DENY_WRITE);
-                }
-                else /* Just query the information without opening the file. */
-                    rc = pObjFile->QueryInfo(DnDURIObject::View_Source);
-
+                /** @todo Add a standard fOpen mode for this list. */
+                rc = pObjFile->Open(DnDURIObject::View_Source, RTFILE_O_OPEN | RTFILE_O_READ | RTFILE_O_DENY_WRITE);
                 if (RT_SUCCESS(rc))
                 {
@@ -79 +73 @@
                     m_cTotal++;
                     m_cbTotal += pObjFile->GetSize();
+
+                    if (!(fFlags & DNDURILIST_FLAGS_KEEP_OPEN)) /* Shall we keep the file open while being added to this list? */
+                        pObjFile->Close();
                 }
                 else