Changeset 78033 in vbox for trunk/src

Timestamp:

Apr 6, 2019 6:07:58 PM (6 years ago)

Author:

vboxsync

Message:

Main/HostDnsServiceDarwin: Add and remove the stop source object in the thread function for consistentcy. Also should fix the startup crashes.

File:

• trunk/src/VBox/Main/src-server/darwin/HostDnsServiceDarwin.cpp (modified) (4 diffs)

trunk/src/VBox/Main/src-server/darwin/HostDnsServiceDarwin.cpp

@@ -91 +91 @@
     AssertReturn(m->m_SourceStop, E_FAIL);
 
-    CFRunLoopAddSource(m->m_RunLoopRef, m->m_SourceStop, kCFRunLoopCommonModes);
-
     HRESULT hrc = HostDnsServiceBase::init(pProxy);
     return hrc;
@@ -101 +99 @@
     HostDnsServiceBase::uninit();
 
-    CFRunLoopRemoveSource(m->m_RunLoopRef, m->m_SourceStop, kCFRunLoopCommonModes);
     CFRelease(m->m_SourceStop);
-
     CFRelease(m->m_RunLoopRef);
-
     CFRelease(m->m_DnsWatcher);
-
     CFRelease(m->m_store);
 
@@ -134 +128 @@
 
     CFRetain(m->m_RunLoopRef);
+
+    CFRunLoopAddSource(m->m_RunLoopRef, m->m_SourceStop, kCFRunLoopCommonModes);
 
     CFArrayRef watchingArrayRef = CFArrayCreate(NULL,
@@ -159 +155 @@
         CFRunLoopRun();
     }
+
+    CFRunLoopRemoveSource(m->m_RunLoopRef, m->m_SourceStop, kCFRunLoopCommonModes);
 
     /* We're notifying stopper thread. */