Changeset 78066 in vbox for trunk/src/VBox/Frontends

Timestamp:

Apr 9, 2019 4:02:32 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

129919

Message:

IPRT,GUI: Workaround for certificate downloads getting redirected to https.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/net

Files:

• UINetworkReply.cpp (modified) (3 diffs)
• tstSSLCertDownloads.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/net/UINetworkReply.cpp

@@ -777 +777 @@
     NOREF(pStaticErrInfo);
     int rc;
+
+    /*
+     * Must disable SSL certification verification here as we cannot use the
+     * SSL certificates before we've downloaded them.   We must also enable
+     * redirections in case the certificates moves around.
+     */
+    bool const     fSavedVerifyPeer   = RTHttpGetVerifyPeer(hHttp);
+    uint32_t const cSavedMaxRedirects = RTHttpGetFollowRedirects(hHttp);
+    RTHttpSetVerifyPeer(hHttp, false);
+    RTHttpSetFollowRedirects(hHttp, 8);
 
     /*
@@ -810 +820 @@
                                 {
                                     RTHttpFreeResponse(pvRootsZip);
+                                    RTHttpSetVerifyPeer(hHttp, fSavedVerifyPeer);
+                                    RTHttpSetFollowRedirects(hHttp, cSavedMaxRedirects);
                                     return;
                                 }
@@ -845 +857 @@
                 }
         }
+
+    RTHttpSetVerifyPeer(hHttp, fSavedVerifyPeer);
+    RTHttpSetFollowRedirects(hHttp, cSavedMaxRedirects);
 }
 

trunk/src/VBox/Frontends/VirtualBox/src/net/tstSSLCertDownloads.cpp

@@ -57 +57 @@
     int rc;
 
+    bool const     fSavedVerifyPeer   = RTHttpGetVerifyPeer(TestObj.m_hHttp);
+    uint32_t const cSavedMaxRedirects = RTHttpGetFollowRedirects(TestObj.m_hHttp);
+    RTTESTI_CHECK_RC(RTHttpSetVerifyPeer(TestObj.m_hHttp, false), VINF_SUCCESS);
+    RTTESTI_CHECK_RC(RTHttpSetFollowRedirects(TestObj.m_hHttp, 8), VINF_SUCCESS);
+    RTTESTI_CHECK(RTHttpGetVerifyPeer(TestObj.m_hHttp) == false);
+    RTTESTI_CHECK(RTHttpGetFollowRedirects(TestObj.m_hHttp) == 8);
+
     /* ZIP files: */
     for (uint32_t iUrl = 0; iUrl < RT_ELEMENTS(s_apszRootsZipUrls); iUrl++)
@@ -113 +120 @@
     RTTESTI_CHECK(RTCrStoreRelease(hStore) == 0);
 
+    RTTESTI_CHECK_RC(RTHttpSetVerifyPeer(TestObj.m_hHttp, fSavedVerifyPeer), VINF_SUCCESS);
+    RTTESTI_CHECK_RC(RTHttpSetFollowRedirects(TestObj.m_hHttp, cSavedMaxRedirects), VINF_SUCCESS);
+
     /*
      * Now check the gathering of certificates on the system doesn't crash.