Changeset 78068 in vbox

Timestamp:

Apr 10, 2019 9:38:27 AM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

129924

Message:

Recording/Main: Some renaming, comment fixes.

Location:

trunk/src/VBox/Main

Files:

• include/RecordingScreenSettingsImpl.h (modified) (1 diff)
• include/RecordingSettingsImpl.h (modified) (1 diff)
• src-server/RecordingScreenSettingsImpl.cpp (modified) (6 diffs)
• src-server/RecordingSettingsImpl.cpp (modified) (5 diffs)

trunk/src/VBox/Main/include/RecordingScreenSettingsImpl.h

@@ -44 +44 @@
 
     // public initializer/uninitializer for internal purposes only
-    HRESULT init(RecordingSettings *aParent, uint32_t uScreenId, const settings::RecordingScreenSettings& data);
-    HRESULT init(RecordingSettings *aParent, RecordingScreenSettings *that);
-    HRESULT initCopy(RecordingSettings *aParent, RecordingScreenSettings *that);
+    HRESULT init(RecordingSettings *aParent, uint32_t uScreenId, const settings::RecordingScreenSettings& aThat);
+    HRESULT init(RecordingSettings *aParent, RecordingScreenSettings *aThat);
+    HRESULT initCopy(RecordingSettings *aParent, RecordingScreenSettings *aThat);
     void uninit();
-
-    // public methods only for internal purposes
-    HRESULT i_loadSettings(const settings::RecordingScreenSettings &data);
-    HRESULT i_saveSettings(settings::RecordingScreenSettings &data);
-
-    void i_rollback();
-    void i_commit();
-    void i_copyFrom(RecordingScreenSettings *aThat);
-    void i_applyDefaults();
 
 private:

trunk/src/VBox/Main/include/RecordingSettingsImpl.h

@@ -44 +44 @@
     // public initializer/uninitializer for internal purposes only
     HRESULT init(Machine *parent);
-    HRESULT init(Machine *parent, RecordingSettings *that);
-    HRESULT initCopy(Machine *parent, RecordingSettings *that);
+    HRESULT init(Machine *parent, RecordingSettings *aThat);
+    HRESULT initCopy(Machine *parent, RecordingSettings *aThat);
     void uninit();
 

trunk/src/VBox/Main/src-server/RecordingScreenSettingsImpl.cpp

@@ -72 +72 @@
 
 /**
- * Initializes the audio adapter object.
+ * Initializes the recording screen settings object.
  *
  * @returns COM result indicator
  */
-HRESULT RecordingScreenSettings::init(RecordingSettings *aParent, uint32_t uScreenId, const settings::RecordingScreenSettings& data)
+HRESULT RecordingScreenSettings::init(RecordingSettings *aParent, uint32_t uScreenId,
+                                      const settings::RecordingScreenSettings& aThat)
 {
     LogFlowThisFuncEnter();
@@ -96 +97 @@
     m->uScreenId = uScreenId;
     m->bd.allocate();
-    m->bd->operator=(data);
+    m->bd->operator=(aThat);
 
     HRESULT rc = S_OK;
@@ -123 +124 @@
  *  it shares data with is destroyed.
  */
-HRESULT RecordingScreenSettings::init(RecordingSettings *aParent, RecordingScreenSettings *that)
+HRESULT RecordingScreenSettings::init(RecordingSettings *aParent, RecordingScreenSettings *aThat)
 {
     LogFlowThisFuncEnter();
-    LogFlowThisFunc(("aParent: %p, that: %p\n", aParent, that));
-
-    ComAssertRet(aParent && that, E_INVALIDARG);
+    LogFlowThisFunc(("aParent: %p, aThat: %p\n", aParent, aThat));
+
+    ComAssertRet(aParent && aThat, E_INVALIDARG);
 
     /* Enclose the state transition NotReady->InInit->Ready */
@@ -137 +138 @@
 
     unconst(m->pParent) = aParent;
-    m->pPeer = that;
-
-    AutoWriteLock thatlock(that COMMA_LOCKVAL_SRC_POS);
-
-    m->uScreenId = that->m->uScreenId;
-    m->bd.share(that->m->bd);
+    m->pPeer = aThat;
+
+    AutoWriteLock thatlock(aThat COMMA_LOCKVAL_SRC_POS);
+
+    m->uScreenId = aThat->m->uScreenId;
+    m->bd.share(aThat->m->bd);
 
     HRESULT rc = S_OK;
@@ -166 +167 @@
  *  of the original object passed as an argument.
  */
-HRESULT RecordingScreenSettings::initCopy(RecordingSettings *aParent, RecordingScreenSettings *that)
+HRESULT RecordingScreenSettings::initCopy(RecordingSettings *aParent, RecordingScreenSettings *aThat)
 {
     LogFlowThisFuncEnter();
-    LogFlowThisFunc(("aParent: %p, that: %p\n", aParent, that));
-
-    ComAssertRet(aParent && that, E_INVALIDARG);
+    LogFlowThisFunc(("aParent: %p, aThat: %p\n", aParent, aThat));
+
+    ComAssertRet(aParent && aThat, E_INVALIDARG);
 
     /* Enclose the state transition NotReady->InInit->Ready */
@@ -182 +183 @@
     /* mPeer is left null. */
 
-    AutoWriteLock thatlock(that COMMA_LOCKVAL_SRC_POS);
-
-    m->uScreenId = that->m->uScreenId;
-    m->bd.attachCopy(that->m->bd);
+    AutoWriteLock thatlock(aThat COMMA_LOCKVAL_SRC_POS);
+
+    m->uScreenId = aThat->m->uScreenId;
+    m->bd.attachCopy(aThat->m->bd);
 
     HRESULT rc = S_OK;

trunk/src/VBox/Main/src-server/RecordingSettingsImpl.cpp

@@ -65 +65 @@
 
 /**
- * Initializes the audio adapter object.
+ * Initializes the recording settings object.
  *
  * @returns COM result indicator
@@ -101 +101 @@
  *  it shares data with is destroyed.
  */
-HRESULT RecordingSettings::init(Machine *aParent, RecordingSettings *that)
-{
-    LogFlowThisFuncEnter();
-    LogFlowThisFunc(("aParent: %p, that: %p\n", aParent, that));
-
-    ComAssertRet(aParent && that, E_INVALIDARG);
+HRESULT RecordingSettings::init(Machine *aParent, RecordingSettings *aThat)
+{
+    LogFlowThisFuncEnter();
+    LogFlowThisFunc(("aParent: %p, aThat: %p\n", aParent, aThat));
+
+    ComAssertRet(aParent && aThat, E_INVALIDARG);
 
     /* Enclose the state transition NotReady->InInit->Ready */
@@ -115 +115 @@
 
     unconst(m->pMachine) = aParent;
-    m->pPeer = that;
-
-    AutoWriteLock thatlock(that COMMA_LOCKVAL_SRC_POS);
-
-    m->bd.share(that->m->bd);
-    m->mapScreenObj = that->m->mapScreenObj;
+    m->pPeer = aThat;
+
+    AutoWriteLock thatlock(aThat COMMA_LOCKVAL_SRC_POS);
+
+    m->bd.share(aThat->m->bd);
+    m->mapScreenObj = aThat->m->mapScreenObj;
 
     autoInitSpan.setSucceeded();
@@ -133 +133 @@
  *  of the original object passed as an argument.
  */
-HRESULT RecordingSettings::initCopy(Machine *aParent, RecordingSettings *that)
-{
-    LogFlowThisFuncEnter();
-    LogFlowThisFunc(("aParent: %p, that: %p\n", aParent, that));
-
-    ComAssertRet(aParent && that, E_INVALIDARG);
+HRESULT RecordingSettings::initCopy(Machine *aParent, RecordingSettings *aThat)
+{
+    LogFlowThisFuncEnter();
+    LogFlowThisFunc(("aParent: %p, aThat: %p\n", aParent, aThat));
+
+    ComAssertRet(aParent && aThat, E_INVALIDARG);
 
     /* Enclose the state transition NotReady->InInit->Ready */
@@ -149 +149 @@
     // mPeer is left null
 
-    AutoWriteLock thatlock(that COMMA_LOCKVAL_SRC_POS);
-
-    m->bd.attachCopy(that->m->bd);
-    m->mapScreenObj = that->m->mapScreenObj;
+    AutoWriteLock thatlock(aThat COMMA_LOCKVAL_SRC_POS);
+
+    m->bd.attachCopy(aThat->m->bd);
+    m->mapScreenObj = aThat->m->mapScreenObj;
 
     autoInitSpan.setSucceeded();