Changeset 78076 in vbox for trunk/src/VBox/GuestHost/OpenGL/include

Timestamp:

Apr 10, 2019 11:20:02 AM (6 years ago)

Author:

vboxsync

Message:

GuestHost/OpenGL,HostServices/SharedOpenGL: Fixed parameter validation, bugref:9433

File:

• trunk/src/VBox/GuestHost/OpenGL/include/cr_unpack.h (modified) (2 diffs)

trunk/src/VBox/GuestHost/OpenGL/include/cr_unpack.h

@@ -83 +83 @@
 #define SET_RETURN_PTR( offset ) do { \
         CRDBGPTR_CHECKZ(return_ptr); \
+        if (!DATA_POINTER_CHECK(offset + sizeof(*return_ptr))) \
+        { \
+             crError("%s: SET_RETURN_PTR(%u) offset out of bounds\n", __FUNCTION__, offset); \
+             return; \
+        } \
         crMemcpy( return_ptr, cr_unpackData + (offset), sizeof( *return_ptr ) ); \
     } while (0);
@@ -89 +94 @@
 #define SET_WRITEBACK_PTR( offset ) do { \
         CRDBGPTR_CHECKZ(writeback_ptr); \
+        if (!DATA_POINTER_CHECK(offset + sizeof(*writeback_ptr))) \
+        { \
+             crError("%s: SET_WRITEBACK_PTR(%u) offset out of bounds\n", __FUNCTION__, offset); \
+             return; \
+        } \
         crMemcpy( writeback_ptr, cr_unpackData + (offset), sizeof( *writeback_ptr ) ); \
     } while (0);