Changeset 78211 in vbox for trunk

Timestamp:

Apr 18, 2019 4:16:24 PM (6 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9434: Import Appliance wizard: Form Editor widget: Update table on generation value changes.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/wizards/importappliance/UIFormEditorWidget.cpp (modified) (10 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/wizards/importappliance/UIFormEditorWidget.cpp

@@ -171 +171 @@
     void updateValueCells();
 
+    /** Check whether generation value is changed. */
+    bool isGenerationChanged() const;
+
 protected:
 
@@ -191 +194 @@
     KFormValueType  m_enmValueType;
 
+    /** Holds current generation value. */
+    int  m_iGeneration;
+
     /** Holds the cell instances. */
     QVector<UIFormEditorCell*>  m_cells;
@@ -237 +243 @@
     /** Return the parent table-view reference. */
     QITableView *parentTable() const;
+
+    /** Updates row generation values. */
+    void updateGeneration();
 
     /** Holds the Form Editor row list. */
@@ -281 +290 @@
     , m_comValue(comValue)
     , m_enmValueType(KFormValueType_Max)
+    , m_iGeneration(0)
 {
     prepare();
@@ -396 +406 @@
 void UIFormEditorRow::updateValueCells()
 {
+    m_iGeneration = m_comValue.GetGeneration();
+    /// @todo check for errors
+
     switch (m_enmValueType)
     {
@@ -416 +429 @@
             CChoiceFormValue comValue(m_comValue);
             const QVector<QString> values = comValue.GetValues();
-            m_cells[UIFormEditorDataType_Value]->setText(values.at(comValue.GetSelectedIndex()));
+            m_cells[UIFormEditorDataType_Value]->setText(values.isEmpty() ? QString() : values.at(comValue.GetSelectedIndex()));
             /// @todo check for errors
             break;
@@ -423 +436 @@
             break;
     }
+}
+
+bool UIFormEditorRow::isGenerationChanged() const
+{
+    const int iGeneration = m_comValue.GetGeneration();
+    /// @todo check for errors
+    return m_iGeneration != iGeneration;
 }
 
@@ -573 +593 @@
                         m_dataList[index.row()]->setBool(enmCheckState == Qt::Checked);
                         emit dataChanged(index, index);
+                        updateGeneration();
                         return true;
                     }
@@ -595 +616 @@
                             m_dataList[index.row()]->setString(value.toString());
                             emit dataChanged(index, index);
+                            updateGeneration();
                             return true;
                         case KFormValueType_Choice:
                             m_dataList[index.row()]->setChoice(value.value<ChoiceData>());
                             emit dataChanged(index, index);
+                            updateGeneration();
                             return true;
                         default:
@@ -701 +724 @@
 }
 
+void UIFormEditorModel::updateGeneration()
+{
+    foreach (UIFormEditorRow *pRow, m_dataList)
+        if (pRow->isGenerationChanged())
+            pRow->updateValueCells();
+}
+
 
 /*********************************************************************************************************************************