Changeset 78264 in vbox

Timestamp:

Apr 23, 2019 6:53:43 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

130212

Message:

Config.kmk,GuestHost\OpenGL,HostServices\SharedOpenGL: Fix a bunch of compiler warnings and enable them again [build fixes]

Location:

trunk

Files:

• Config.kmk (modified) (1 diff)
• src/VBox/HostServices/SharedOpenGL/crserverlib/presenter/server_presenter.cpp (modified) (1 diff)
• src/VBox/HostServices/SharedOpenGL/unpacker/unpack_shaders.cpp (modified) (2 diffs)

trunk/Config.kmk

@@ -7349 +7349 @@
  TEMPLATE_VBOXCROGLR3HOSTDLL_OBJCFLAGS       = $(TEMPLATE_VBOXR3NP_OBJCFLAGS) -Wno-deprecated-declarations
 else ifeq ($(KBUILD_TARGET),win)
- #   -wd4054: renderspu_wgl.c(281) : warning C4054: 'type cast' : from function pointer 'HWND (__cdecl *)()' to data pointer 'void *'
  #   -wd4055: renderspu.c(1553) : warning C4055: 'type cast' : from data pointer 'const GLvoid *' to function pointer 'PFNVCRSERVER_CLIENT_CALLOUT'
  TEMPLATE_VBOXCROGLR3HOSTDLL_CFLAGS          = $(TEMPLATE_$(TEMPLATE_VBOXCROGLR3HOSTDLL_EXTENDS)_CFLAGS) \

trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/presenter/server_presenter.cpp

@@ -225 +225 @@
     float strY = ((float)dstHeight) / srcHeight;
     bool fScale = (dstWidth != srcWidth || dstHeight != srcHeight);
-    Assert(fScale);
+    Assert(fScale); RT_NOREF(fScale);
 
     /* 'List' contains the destination rectangles to be updated (in pDst coords). */

trunk/src/VBox/HostServices/SharedOpenGL/unpacker/unpack_shaders.cpp

@@ -453 +453 @@
 
     size_t cchStr = CHECK_STRING_FROM_PTR_UPDATE_NO_RETURN(pState, name);
-    if (RT_UNLIKELY(cchStr == ~(size_t)0 || packet_length != cchStr + 2 * sizeof(CRNetworkPointer)))
+    if (RT_UNLIKELY(cchStr == ~(size_t)0U || packet_length != cchStr + 2 * sizeof(CRNetworkPointer)))
     {
         crError("crUnpackExtendGetAttribLocation: packet_length is corrupt");
@@ -474 +474 @@
 
     size_t cchStr = CHECK_STRING_FROM_PTR_UPDATE_NO_RETURN(pState, name);
-    if (RT_UNLIKELY(cchStr == ~(size_t)0 || packet_length != cchStr + 2 * sizeof(CRNetworkPointer)))
+    if (RT_UNLIKELY(cchStr == ~(size_t)0U || packet_length != cchStr + 2 * sizeof(CRNetworkPointer)))
     {
         crError("crUnpackExtendGetUniformLocation: packet_length is corrupt");