Changeset 78283 in vbox for trunk/src

Timestamp:

Apr 24, 2019 5:26:50 PM (6 years ago)

Author:

vboxsync

Message:

winnt/vboxsf: Corrected VERR_FILE_NOT_FOUND translation so FsPerf gets the expected status code when opening non-existing sub-dirs. Seems someone tried to fix this before but for some inexplicable reasons transled it to VERR_PATH_NOT_FOUND. bugref:9172

File:

• trunk/src/VBox/Additions/WINNT/SharedFolders/driver/path.c (modified) (3 diffs)

trunk/src/VBox/Additions/WINNT/SharedFolders/driver/path.c

@@ -284 +284 @@
 
             /* On POSIX systems, the "mkdir" command returns VERR_FILE_NOT_FOUND when
-               doing a recursive directory create. Handle this case. */
-            case VERR_FILE_NOT_FOUND:
+               doing a recursive directory create. Handle this case.
+
+               bird: We end up here on windows systems too if opening a dir that doesn't
+                     exists.  Thus, I've changed the SHFL_PATH_NOT_FOUND to SHFL_FILE_NOT_FOUND
+                     so that FsPerf is happy. */
+            case VERR_FILE_NOT_FOUND: /** @todo r=bird: this is a host bug, isn't it? */
             {
-                pCreateParms->Result = SHFL_PATH_NOT_FOUND;
+                pCreateParms->Result = SHFL_FILE_NOT_FOUND;
                 break;
             }
@@ -307 +311 @@
         case SHFL_PATH_NOT_FOUND:
         {
-            /* Path to object does not exist. */
+            /* Path to the object does not exist. */
             Log(("VBOXSF: vbsfProcessCreate: Path not found\n"));
             *pulCreateAction = FILE_DOES_NOT_EXIST;
@@ -327 +331 @@
             Status = STATUS_UNSUCCESSFUL;
             goto failure;
-
-            break;
         }