Changeset 78294 in vbox for trunk/src/VBox/Frontends

Timestamp:

Apr 25, 2019 11:13:31 AM (6 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:9241: Each time we move focus to to global item as a fallback mean we risk previous item to be removed silently (thus becoming stale as a result), so we should invalidate machine selection to avoid further crash in machine Details pane.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserModel.cpp (modified) (6 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/manager/chooser/UIChooserModel.cpp

@@ -637 +637 @@
         /* Make sure selected-item present, if possible: */
         if (!firstSelectedItem() && !navigationItems().isEmpty())
+        {
             setSelectedItem(navigationItems().first());
+            emit sigSelectionInvalidated();
+        }
         /* Make sure current-item present, if possible: */
         else if (!currentItem() && firstSelectedItem())
@@ -687 +690 @@
         /* Make sure at least one item selected after that: */
         if (!firstSelectedItem() && !navigationItems().isEmpty())
+        {
             setSelectedItem(navigationItems().first());
+            emit sigSelectionInvalidated();
+        }
     }
 
@@ -812 +818 @@
     delete pCurrentNode;
 
-    /* Notify about selection invalidated: */
-    emit sigSelectionInvalidated();
-
     /* And update model: */
     updateNavigationItemList();
@@ -824 +827 @@
     }
     else
+    {
         setSelectedItem(navigationItems().first());
+        emit sigSelectionInvalidated();
+    }
     saveGroupSettings();
 }
@@ -1267 +1273 @@
     setSelectedItem(gEDataManager->selectorWindowLastItemChosen());
     if (!firstSelectedItem() && !navigationItems().isEmpty())
+    {
         setSelectedItem(navigationItems().first());
+        emit sigSelectionInvalidated();
+    }
 }
 
@@ -1485 +1494 @@
     updateLayout();
     if (!navigationItems().isEmpty())
+    {
         setSelectedItem(navigationItems().first());
+        emit sigSelectionInvalidated();
+    }
     else
         clearSelectedItems();