Changeset 78353 in vbox for trunk/src/VBox

Timestamp:

Apr 29, 2019 5:19:02 PM (6 years ago)

Author:

vboxsync

Message:

FE/Qt: bugref:8400. Disabled some medium editing widgets if the current medium is not editable.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/medium

Files:

• UIMediumDetailsWidget.cpp (modified) (8 diffs)
• UIMediumDetailsWidget.h (modified) (9 diffs)
• UIMediumItem.cpp (modified) (3 diffs)
• UIMediumItem.h (modified) (1 diff)
• UIMediumManager.cpp (modified) (7 diffs)
• UIMediumManager.h (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/medium/UIMediumDetailsWidget.cpp

@@ -83 +83 @@
 }
 
+void UIMediumDetailsWidget::enableDisableMediumModificationWidgets(bool fMediumIsModifiable)
+{
+    if (m_pComboBoxType)
+        m_pComboBoxType->setEnabled(fMediumIsModifiable);
+    if (m_pEditorLocation)
+        m_pEditorLocation->setEnabled(fMediumIsModifiable);
+    if (m_pEditorSize)
+        m_pEditorSize->setEnabled(fMediumIsModifiable);
+}
+
 void UIMediumDetailsWidget::setOptionsEnabled(bool fEnabled)
 {
@@ -134 +144 @@
 void UIMediumDetailsWidget::sltTypeIndexChanged(int iIndex)
 {
-    m_newData.m_options.m_enmType = m_pComboBoxType->itemData(iIndex).value<KMediumType>();
+    m_newData.m_options.m_enmMediumType = m_pComboBoxType->itemData(iIndex).value<KMediumType>();
     revalidate(m_pErrorPaneType);
     updateButtonStates();
@@ -620 +630 @@
     {
         /* Populate type combo-box: */
-        switch (m_newData.m_enmType)
+        switch (m_newData.m_enmDeviceType)
         {
             case UIMediumDeviceType_HardDisk:
@@ -626 +636 @@
                 /* No type changes for differencing disks: */
                 if (m_oldData.m_enmVariant & KMediumVariant_Diff)
-                    m_pComboBoxType->addItem(QString(), m_oldData.m_options.m_enmType);
+                    m_pComboBoxType->addItem(QString(), m_oldData.m_options.m_enmMediumType);
                 else
                 {
@@ -664 +674 @@
     /* Choose the item with required type to be the current one: */
     for (int i = 0; i < m_pComboBoxType->count(); ++i)
-        if (m_pComboBoxType->itemData(i).value<KMediumType>() == m_newData.m_options.m_enmType)
+        if (m_pComboBoxType->itemData(i).value<KMediumType>() == m_newData.m_options.m_enmMediumType)
             m_pComboBoxType->setCurrentIndex(i);
     sltTypeIndexChanged(m_pComboBoxType->currentIndex());
@@ -681 +691 @@
     /* Load size: */
     const bool fEnableResize =    m_newData.m_fValid
-                               && m_newData.m_enmType == UIMediumDeviceType_HardDisk
+                               && m_newData.m_enmDeviceType == UIMediumDeviceType_HardDisk
                                && !(m_newData.m_enmVariant & KMediumVariant_Fixed);
     m_pLabelSize->setEnabled(fEnableResize);
@@ -695 +705 @@
 {
     /* Get information-labels just to acquire their number: */
-    const QList<QLabel*> aLabels = m_aLabels.value(m_newData.m_enmType, QList<QLabel*>());
+    const QList<QLabel*> aLabels = m_aLabels.value(m_newData.m_enmDeviceType, QList<QLabel*>());
     /* Get information-fields just to acquire their number: */
-    const QList<QILabel*> aFields = m_aFields.value(m_newData.m_enmType, QList<QILabel*>());
+    const QList<QILabel*> aFields = m_aFields.value(m_newData.m_enmDeviceType, QList<QILabel*>());
     /* For each the label => update contents: */
     for (int i = 0; i < aLabels.size(); ++i)
-        infoLabel(m_newData.m_enmType, i)->setText(m_newData.m_details.m_aLabels.value(i, QString()));
+        infoLabel(m_newData.m_enmDeviceType, i)->setText(m_newData.m_details.m_aLabels.value(i, QString()));
     /* For each the field => update contents: */
     for (int i = 0; i < aFields.size(); ++i)
     {
-        infoField(m_newData.m_enmType, i)->setText(m_newData.m_details.m_aFields.value(i, QString()));
-        infoField(m_newData.m_enmType, i)->setEnabled(!infoField(m_newData.m_enmType, i)->text().trimmed().isEmpty());
+        infoField(m_newData.m_enmDeviceType, i)->setText(m_newData.m_details.m_aFields.value(i, QString()));
+        infoField(m_newData.m_enmDeviceType, i)->setEnabled(!infoField(m_newData.m_enmDeviceType, i)->text().trimmed().isEmpty());
     }
 }
@@ -846 +856 @@
     return aFields.value(iIndex, 0);
 }
-

trunk/src/VBox/Frontends/VirtualBox/src/medium/UIMediumDetailsWidget.h

@@ -54 +54 @@
     /** Constructs data. */
     UIDataMediumOptions()
-        : m_enmType(KMediumType_Normal)
+        : m_enmMediumType(KMediumType_Normal)
         , m_strLocation(QString())
         , m_strDescription(QString())
@@ -64 +64 @@
     {
         return true
-               && (m_enmType == other.m_enmType)
+               && (m_enmMediumType == other.m_enmMediumType)
                && (m_strLocation == other.m_strLocation)
                && (m_strDescription == other.m_strDescription)
@@ -76 +76 @@
     bool operator!=(const UIDataMediumOptions &other) const { return !equal(other); }
 
-    /** Holds the type. */
-    KMediumType m_enmType;
+    /** Holds the medium type. */
+    KMediumType m_enmMediumType;
     /** Holds the location. */
     QString m_strLocation;
@@ -123 +123 @@
     UIDataMedium()
         : m_fValid(false)
-        , m_enmType(UIMediumDeviceType_Invalid)
+        , m_enmDeviceType(UIMediumDeviceType_Invalid)
         , m_enmVariant(KMediumVariant_Max)
         , m_fHasChildren(false)
@@ -133 +133 @@
     UIDataMedium(UIMediumDeviceType enmType)
         : m_fValid(false)
-        , m_enmType(enmType)
+        , m_enmDeviceType(enmType)
         , m_enmVariant(KMediumVariant_Max)
         , m_fHasChildren(false)
@@ -145 +145 @@
         return true
                && (m_fValid == other.m_fValid)
-               && (m_enmType == other.m_enmType)
+               && (m_enmDeviceType == other.m_enmDeviceType)
                && (m_enmVariant == other.m_enmVariant)
                && (m_fHasChildren == other.m_fHasChildren)
@@ -161 +161 @@
     bool m_fValid;
     /** Holds the medium type. */
-    UIMediumDeviceType m_enmType;
+    UIMediumDeviceType m_enmDeviceType;
     /** Holds the medium variant. */
     KMediumVariant m_enmVariant;
@@ -204 +204 @@
     /** Defines the @a data for passed @a enmType. */
     void setData(const UIDataMedium &data);
+    /** Enables/disables some of the medium editing widgets of the details tab. */
+    void enableDisableMediumModificationWidgets(bool fMediumIsModifiable);
+
 
 public slots:
@@ -355 +358 @@
 
 #endif /* !FEQT_INCLUDED_SRC_medium_UIMediumDetailsWidget_h */
-

trunk/src/VBox/Frontends/VirtualBox/src/medium/UIMediumItem.cpp

@@ -174 +174 @@
 }
 
+bool UIMediumItem::isMediumModifiable() const
+{
+    if (medium().isNull())
+        return false;
+    foreach (const QUuid &uMachineId, medium().curStateMachineIds())
+    {
+        CMachine comMachine = vboxGlobal().virtualBox().FindMachine(uMachineId.toString());
+        if (comMachine.isNull())
+            continue;
+        if (comMachine.GetState() != KMachineState_PoweredOff &&
+            comMachine.GetState() != KMachineState_Aborted)
+            return false;
+    }
+    return true;
+}
+
+bool UIMediumItem::isMediumAttachedTo(QUuid uId)
+{
+   if (medium().isNull())
+        return false;
+   return medium().curStateMachineIds().contains(uId);
+}
+
 QString UIMediumItem::defaultText() const
 {
@@ -197 +220 @@
     m_fValid =    !m_guiMedium.isNull()
                && m_guiMedium.state() != KMediumState_Inaccessible;
-    m_enmType = m_guiMedium.type();
+    m_enmDeviceType = m_guiMedium.type();
     m_enmVariant = m_guiMedium.mediumVariant();
     m_fHasChildren = m_guiMedium.hasChildren();
     /* Gather medium options data: */
-    m_options.m_enmType = m_guiMedium.mediumType();
+    m_options.m_enmMediumType = m_guiMedium.mediumType();
     m_options.m_strLocation = m_guiMedium.location();
     m_options.m_uLogicalSize = m_guiMedium.logicalSizeInBytes();
@@ -207 +230 @@
     /* Gather medium details data: */
     m_details.m_aFields.clear();
-    switch (m_enmType)
+    switch (m_enmDeviceType)
     {
         case UIMediumDeviceType_HardDisk:

trunk/src/VBox/Frontends/VirtualBox/src/medium/UIMediumItem.h

@@ -104 +104 @@
     /** Returns whether <i>this</i> item is less than @a other one. */
     bool operator<(const QTreeWidgetItem &other) const;
+    /** Returns whether the medium can be modified. For
+      * simplicity's sake this returns false if one of the attached vms is not
+      * in PoweredOff or Aborted state. */
+    bool isMediumModifiable() const;
+    /** Returns true if the medium is attached to the vm with @p uId. */
+    bool isMediumAttachedTo(QUuid uId);
 
 protected:

trunk/src/VBox/Frontends/VirtualBox/src/medium/UIMediumManager.cpp

@@ -43 +43 @@
 #include "UIIconPool.h"
 #include "UIMedium.h"
+#include "UIVirtualBoxEventHandler.h"
 
 /* COM includes: */
@@ -271 +272 @@
     /* Try to assign new medium type: */
     if (   comMedium.isOk()
-        && newData.m_options.m_enmType != oldData.m_options.m_enmType)
+        && newData.m_options.m_enmMediumType != oldData.m_options.m_enmMediumType)
     {
         /* Check if we need to release medium first: */
         bool fDo = true;
         if (   pMediumItem->machineIds().size() > 1
-            || (   (   newData.m_options.m_enmType == KMediumType_Immutable
-                    || newData.m_options.m_enmType == KMediumType_MultiAttach)
+            || (   (   newData.m_options.m_enmMediumType == KMediumType_Immutable
+                    || newData.m_options.m_enmMediumType == KMediumType_MultiAttach)
                 && pMediumItem->machineIds().size() > 0))
             fDo = pMediumItem->release(true);
@@ -283 +284 @@
         if (fDo)
         {
-            comMedium.SetType(newData.m_options.m_enmType);
+            comMedium.SetType(newData.m_options.m_enmMediumType);
 
             /* Show error message if necessary: */
             if (!comMedium.isOk())
-                msgCenter().cannotChangeMediumType(comMedium, oldData.m_options.m_enmType, newData.m_options.m_enmType, this);
+                msgCenter().cannotChangeMediumType(comMedium, oldData.m_options.m_enmMediumType, newData.m_options.m_enmMediumType, this);
         }
     }
@@ -486 +487 @@
 }
 
+void UIMediumManagerWidget::sltHandleMachineStateChange(const QUuid &uId, const KMachineState state)
+{
+    UIMediumItem *pCurrentItem = currentMediumItem();
+    if (!pCurrentItem)
+        return;
+    /* If this machine is not using the current medium then we don't care about its state: */
+    if (!pCurrentItem->isMediumAttachedTo(uId))
+        return;
+    bool fMediumIsModifiable = true;
+    if (state != KMachineState_Aborted && state != KMachineState_PoweredOff)
+        fMediumIsModifiable = false;
+    m_pDetailsWidget->enableDisableMediumModificationWidgets(fMediumIsModifiable);
+}
+
 void UIMediumManagerWidget::sltAddMedium()
 {
@@ -719 +734 @@
 void UIMediumManagerWidget::prepareConnections()
 {
+    /* Listen to vm state changed event so that we can disable/enable widgets related to the current medium if neds be: */
+    connect(gVBoxEvents, &UIVirtualBoxEventHandler::sigMachineStateChange,
+            this, &UIMediumManagerWidget::sltHandleMachineStateChange);
+
     /* Configure medium-processing connections: */
     connect(&vboxGlobal(), &VBoxGlobal::sigMediumCreated,
@@ -1040 +1059 @@
     /* Update details-widget: */
     if (m_pDetailsWidget)
+    {
         m_pDetailsWidget->setData(pMediumItem ? *pMediumItem : UIDataMedium(type));
+        if (pMediumItem)
+            m_pDetailsWidget->enableDisableMediumModificationWidgets(currentMediumItem()->isMediumModifiable());
+    }
 }
 
@@ -1594 +1617 @@
 
 /*********************************************************************************************************************************
-*   Class UIMediumManagerFactory implementation.                                                                                 *
+*   Class UIMediumManager implementation.                                                                                 *
 *********************************************************************************************************************************/
 

trunk/src/VBox/Frontends/VirtualBox/src/medium/UIMediumManager.h

@@ -162 +162 @@
         /** Handles VBoxGlobal::sigMediumEnumerationFinished signal. */
         void sltHandleMediumEnumerationFinish();
+        void sltHandleMachineStateChange(const QUuid &uId, const KMachineState state);
     /** @} */