Changeset 78417 in vbox for trunk/src/VBox/Main/glue

Timestamp:

May 6, 2019 11:24:31 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

130414

Message:

Utf8Str,RTCString: Assert that C-string pointer parameters in assignment type operations don't point into the object they're being assigned to, as that will lead to use-afer-free situations. bugref:9448

File:

• trunk/src/VBox/Main/glue/string.cpp (modified) (2 diffs)

trunk/src/VBox/Main/glue/string.cpp

@@ -328 +328 @@
  * @param   a_pcszSrc   The source string.
  * @param   a_offSrc    Start offset to copy from.
- * @param   a_cchSrc    The source string.
+ * @param   a_cchSrc    How much to copy
  * @returns S_OK or E_OUTOFMEMORY.
  *
@@ -336 +336 @@
 HRESULT Utf8Str::copyFromExNComRC(const char *a_pcszSrc, size_t a_offSrc, size_t a_cchSrc)
 {
+    Assert(!a_cchSrc || !m_psz || (uintptr_t)&a_pcszSrc[a_offSrc] - (uintptr_t)m_psz >= (uintptr_t)m_cbAllocated);
     cleanup();
     if (a_cchSrc)