Changeset 78425 in vbox for trunk/src

Timestamp:

May 7, 2019 10:15:39 AM (6 years ago)

Author:

vboxsync

Message:

iprt/asm-amd64-x86.h: Don't use readeflags & writeeflags as they (or at least the latter) seems to confuse compiler optimizations and also is said to have other reordering issues. bugref:9180

Location:

trunk/src/VBox

Files:

• Runtime/common/asm/ASMGetFlags.asm (moved) (moved from trunk/src/VBox/Runtime/win/amd64/ASMGetFlags.asm ) (2 diffs)
• Runtime/common/asm/ASMSetFlags.asm (moved) (moved from trunk/src/VBox/Runtime/win/amd64/ASMSetFlags.asm ) (2 diffs)
• ValidationKit/bootsectors/bs3kit/Makefile.kmk (modified) (1 diff)

trunk/src/VBox/Runtime/common/asm/ASMGetFlags.asm

@@ +1 @@
+; $Id$
 ;; @file
 ; IPRT - ASMGetFlags().
@@ -32 +33 @@
 
 BEGINPROC_EXPORTED ASMGetFlags
+%if    ARCH_BITS == 32
+        pushfd
+%else
         pushf
-        pop     rax
+%endif
+        pop     xAX
         ret
 ENDPROC ASMGetFlags

trunk/src/VBox/Runtime/common/asm/ASMSetFlags.asm

@@ +1 @@
+; $Id$
 ;; @file
 ; IPRT - ASMSetFlags().
@@ -35 +36 @@
 ; @param rcx  eflags
 BEGINPROC_EXPORTED ASMSetFlags
+%if    ARCH_BITS == 64
+ %ifdef ASM_CALL64_GCC
+        push    rdi
+ %else
         push    rcx
+ %endif
         popfq
+%elif  ARCH_BITS == 32
+        push    dword [esp + 4]
+        popfd
+%elif  ARCH_BITS == 16
+        push    bp
+        mov     bp, sp
+        push    word [bp + 2 + 2]
+        popf
+        leave
+%else
+ %error ARCH_BITS
+%endif
         ret
 ENDPROC ASMSetFlags

trunk/src/VBox/ValidationKit/bootsectors/bs3kit/Makefile.kmk

@@ -235 +235 @@
        ../../../Runtime/common/asm/ASMGetXcr0.asm \
        ../../../Runtime/common/asm/ASMSetXcr0.asm \
+       ../../../Runtime/common/asm/ASMSetFlags.asm \
+       ../../../Runtime/common/asm/ASMGetFlags.asm \
 
 # The 16-bit BS3Kit library.