Changeset 78439 in vbox

Timestamp:

May 7, 2019 5:41:25 PM (6 years ago)

Author:

vboxsync

Message:

Shared Clipboard/HostSvc: Logging adjustments.

File:

• trunk/src/VBox/HostServices/SharedClipboard/VBoxSharedClipboardSvc.cpp (modified) (32 diffs)

trunk/src/VBox/HostServices/SharedClipboard/VBoxSharedClipboardSvc.cpp

@@ -202 +202 @@
     if (pClient->fMsgQuit)
     {
-        LogRelFlow(("vboxSvcClipboardReturnMsg: Quit\n"));
+        LogFlowFunc(("vboxSvcClipboardReturnMsg: Quit\n"));
         VBoxHGCMParmUInt32Set(&paParms[0], VBOX_SHARED_CLIPBOARD_HOST_MSG_QUIT);
         VBoxHGCMParmUInt32Set(&paParms[1], 0);
@@ -211 +211 @@
         uint32_t fFormat = 0;
 
-        LogRelFlow(("vboxSvcClipboardReturnMsg: ReadData %02X\n", pClient->u32RequestedFormat));
+        LogFlowFunc(("vboxSvcClipboardReturnMsg: ReadData %02X\n", pClient->u32RequestedFormat));
         if (pClient->u32RequestedFormat & VBOX_SHARED_CLIPBOARD_FMT_UNICODETEXT)
             fFormat = VBOX_SHARED_CLIPBOARD_FMT_UNICODETEXT;
@@ -228 +228 @@
     else if (pClient->fMsgFormats)
     {
-        LogRelFlow(("vboxSvcClipboardReturnMsg: Formats %02X\n", pClient->u32AvailableFormats));
+        LogFlowFunc(("vboxSvcClipboardReturnMsg: Formats %02X\n", pClient->u32AvailableFormats));
         VBoxHGCMParmUInt32Set(&paParms[0], VBOX_SHARED_CLIPBOARD_HOST_MSG_REPORT_FORMATS);
         VBoxHGCMParmUInt32Set(&paParms[1], pClient->u32AvailableFormats);
@@ -236 +236 @@
     {
         /* No pending messages. */
-        LogRelFlow(("vboxSvcClipboardReturnMsg: no message\n"));
+        LogFlowFunc(("vboxSvcClipboardReturnMsg: no message\n"));
         return false;
     }
@@ -254 +254 @@
             case VBOX_SHARED_CLIPBOARD_HOST_MSG_QUIT:
             {
-                LogRelFlow(("vboxSvcClipboardReportMsg: Quit\n"));
+                LogFlowFunc(("Quit\n"));
                 pClient->fMsgQuit = true;
             } break;
@@ -266 +266 @@
                 }
 
-                LogRelFlow(("vboxSvcClipboardReportMsg: ReadData %02X\n", u32Formats));
+                LogFlowFunc(("ReadData %02X\n", u32Formats));
                 pClient->u32RequestedFormat = u32Formats;
                 pClient->fMsgReadData = true;
@@ -279 +279 @@
                 }
 
-                LogRelFlow(("vboxSvcClipboardReportMsg: Formats %02X\n", u32Formats));
+                LogFlowFunc(("Formats %02X\n", u32Formats));
                 pClient->u32AvailableFormats = u32Formats;
                 pClient->fMsgFormats = true;
@@ -286 +286 @@
             {
                 /* Invalid message. */
-                LogRelFlow(("vboxSvcClipboardReportMsg: invalid message %d\n", u32Msg));
+                LogFlowFunc(("invalid message %d\n", u32Msg));
             } break;
         }
@@ -308 +308 @@
             if (fMessageReturned)
             {
-                LogRelFlow(("vboxSvcClipboardReportMsg: CallComplete\n"));
+                LogFlowFunc(("CallComplete\n"));
                 g_pHelpers->pfnCallComplete(callHandle, VINF_SUCCESS);
             }
@@ -356 +356 @@
     VBOXCLIPBOARDCLIENTDATA *pClient = (VBOXCLIPBOARDCLIENTDATA *)pvClient;
 
-    LogRel2(("svcDisconnect: u32ClientID = %d\n", u32ClientID));
+    LogFunc(("u32ClientID = %d\n", u32ClientID));
 
     vboxSvcClipboardReportMsg(pClient, VBOX_SHARED_CLIPBOARD_HOST_MSG_QUIT, 0);
@@ -400 +400 @@
     }
 
-    LogRel2(("vboxClipboardConnect: rc = %Rrc\n", rc));
-
+    LogFlowFuncLeaveRC(rc);
     return rc;
 }
@@ -417 +416 @@
     int rc = VINF_SUCCESS;
 
-    LogRel2(("svcCall: u32ClientID = %d, fn = %d, cParms = %d, pparms = %d\n",
+    LogFunc(("u32ClientID = %d, fn = %d, cParms = %d, pparms = %d\n",
              u32ClientID, u32Function, cParms, paParms));
 
@@ -430 +429 @@
     {
         /** @todo parameters other than 32 bit */
-        LogRel2(("    pparms[%d]: type %d value %d\n", i, paParms[i].type, paParms[i].u.uint32));
+        LogFunc(("    pparms[%d]: type %d value %d\n", i, paParms[i].type, paParms[i].u.uint32));
     }
 #endif
@@ -439 +438 @@
         {
             /* The quest requests a host message. */
-            LogRel2(("svcCall: VBOX_SHARED_CLIPBOARD_FN_GET_HOST_MSG\n"));
+            LogFunc(("VBOX_SHARED_CLIPBOARD_FN_GET_HOST_MSG\n"));
 
             if (cParms != VBOX_SHARED_CLIPBOARD_CPARMS_GET_HOST_MSG)
@@ -472 +471 @@
                         pClient->async.paParms    = paParms;
 
-                        LogRel2(("svcCall: async.\n"));
+                        LogFunc(("async.\n"));
                     }
 
@@ -487 +486 @@
         {
             /* The guest reports that some formats are available. */
-            LogRel2(("svcCall: VBOX_SHARED_CLIPBOARD_FN_FORMATS\n"));
+            LogFunc(("VBOX_SHARED_CLIPBOARD_FN_FORMATS\n"));
 
             if (cParms != VBOX_SHARED_CLIPBOARD_CPARMS_FORMATS)
@@ -532 +531 @@
         {
             /* The guest wants to read data in the given format. */
-            LogRel2(("svcCall: VBOX_SHARED_CLIPBOARD_FN_READ_DATA\n"));
+            LogFunc(("VBOX_SHARED_CLIPBOARD_FN_READ_DATA\n"));
 
             if (cParms != VBOX_SHARED_CLIPBOARD_CPARMS_READ_DATA)
@@ -578 +577 @@
                             g_fReadingData = true;
                             rc = g_pfnExtension (g_pvExtension, VBOX_CLIPBOARD_EXT_FN_DATA_READ, &parms, sizeof (parms));
-                            LogRelFlow(("DATA: g_fDelayedAnnouncement = %d, g_u32DelayedFormats = 0x%x\n", g_fDelayedAnnouncement, g_u32DelayedFormats));
+                            LogFlowFunc(("DATA: g_fDelayedAnnouncement = %d, g_u32DelayedFormats = 0x%x\n", g_fDelayedAnnouncement, g_u32DelayedFormats));
                             if (g_fDelayedAnnouncement)
                             {
@@ -628 +627 @@
         {
             /* The guest writes the requested data. */
-            LogRel2(("svcCall: VBOX_SHARED_CLIPBOARD_FN_WRITE_DATA\n"));
+            LogFunc(("VBOX_SHARED_CLIPBOARD_FN_WRITE_DATA\n"));
 
             if (cParms != VBOX_SHARED_CLIPBOARD_CPARMS_WRITE_DATA)
@@ -686 +685 @@
     }
 
-    LogRelFlow(("svcCall: rc = %Rrc\n", rc));
+    LogFlowFunc(("rc = %Rrc\n", rc));
 
     if (!fAsynchronousProcessing)
@@ -727 +726 @@
     int rc = VINF_SUCCESS;
 
-    LogRel2(("svcHostCall: fn = %d, cParms = %d, pparms = %d\n",
+    LogFunc(("svcHostCall: fn = %d, cParms = %d, pparms = %d\n",
              u32Function, cParms, paParms));
 
@@ -734 +733 @@
         case VBOX_SHARED_CLIPBOARD_HOST_FN_SET_MODE:
         {
-            LogRel2(("svcCall: VBOX_SHARED_CLIPBOARD_HOST_FN_SET_MODE\n"));
+            LogFunc(("VBOX_SHARED_CLIPBOARD_HOST_FN_SET_MODE\n"));
 
             if (cParms != 1)
@@ -765 +764 @@
             rc = VBoxHGCMParmUInt32Get (&paParms[0], &u32Headless);
             if (RT_SUCCESS(rc))
-                LogRelFlow(("svcCall: VBOX_SHARED_CLIPBOARD_HOST_FN_SET_HEADLESS, u32Headless=%u\n",
+                LogFlowFunc(("VBOX_SHARED_CLIPBOARD_HOST_FN_SET_HEADLESS, u32Headless=%u\n",
                             (unsigned) u32Headless));
             g_fHeadless = RT_BOOL(u32Headless);
@@ -774 +773 @@
     }
 
-    LogRelFlow(("svcHostCall: rc = %Rrc\n", rc));
+    LogFlowFunc(("svcHostCall: rc = %Rrc\n", rc));
     return rc;
 }
@@ -802 +801 @@
      * Pending requests, if any, will be completed in svcDisconnect.
      */
-    LogRel2(("svcSaveState: u32ClientID = %d\n", u32ClientID));
+    LogFunc(("u32ClientID = %d\n", u32ClientID));
 
     VBOXCLIPBOARDCLIENTDATA *pClient = (VBOXCLIPBOARDCLIENTDATA *)pvClient;
@@ -866 +865 @@
 #ifndef UNIT_TEST
     RT_NOREF(uVersion);
-    LogRel2(("svcLoadState: u32ClientID = %d\n", u32ClientID));
+
+    LogFunc(("u32ClientID = %d\n", u32ClientID));
 
     VBOXCLIPBOARDCLIENTDATA *pClient = (VBOXCLIPBOARDCLIENTDATA *)pvClient;
@@ -921 +921 @@
     else
     {
-        LogRel(("Client data size mismatch: got %#x\n", lenOrVer));
+        LogFunc(("Client data size mismatch: got %#x\n", lenOrVer));
         return VERR_SSM_DATA_UNIT_FORMAT_CHANGED;
     }
@@ -928 +928 @@
     if (pClient->u32ClientID != u32ClientIDOld)
     {
-        LogRel(("Client ID mismatch: expected %d, got %d\n", u32ClientIDOld, pClient->u32ClientID));
+        LogFunc(("Client ID mismatch: expected %d, got %d\n", u32ClientIDOld, pClient->u32ClientID));
         pClient->u32ClientID = u32ClientIDOld;
         return VERR_SSM_DATA_UNIT_FORMAT_CHANGED;
@@ -951 +951 @@
             case VBOX_CLIPBOARD_EXT_FN_FORMAT_ANNOUNCE:
             {
-                LogRelFlow(("ANNOUNCE: g_fReadingData = %d\n", g_fReadingData));
+                LogFlowFunc(("ANNOUNCE: g_fReadingData = %d\n", g_fReadingData));
                 if (g_fReadingData)
                 {
@@ -978 +978 @@
 static DECLCALLBACK(int) svcRegisterExtension(void *, PFNHGCMSVCEXT pfnExtension, void *pvExtension)
 {
-    LogRelFlowFunc(("pfnExtension = %p\n", pfnExtension));
+    LogFlowFunc(("pfnExtension=%p\n", pfnExtension));
 
     VBOXCLIPBOARDEXTPARMS parms;
@@ -1011 +1011 @@
     int rc = VINF_SUCCESS;
 
-    LogRelFlowFunc(("ptable = %p\n", ptable));
+    LogFlowFunc(("ptable=%p\n", ptable));
 
     if (!ptable)
@@ -1019 +1019 @@
     else
     {
-        LogRel2(("VBoxHGCMSvcLoad: ptable->cbSize = %d, ptable->u32Version = 0x%08X\n", ptable->cbSize, ptable->u32Version));
+        LogFunc(("ptable->cbSize = %d, ptable->u32Version = 0x%08X\n", ptable->cbSize, ptable->u32Version));
 
         if (   ptable->cbSize     != sizeof (VBOXHGCMSVCFNTABLE)