Changeset 7862 in vbox

Timestamp:

Apr 10, 2008 9:18:44 AM (17 years ago)

Author:

vboxsync

Message:

HGCM service must not block: added todo for SHFL_LOCK_WAIT (Shared folders).

File:

• trunk/src/VBox/HostServices/SharedFolders/service.cpp (modified) (3 diffs)

trunk/src/VBox/HostServices/SharedFolders/service.cpp

@@ -281 +281 @@
     SHFLCLIENTDATA *pClient = (SHFLCLIENTDATA *)pvClient;
 
-    uint8_t AsynchronousProcessing = 0;
+    bool fAsynchronousProcessing = false;
 
 #ifdef DEBUG
@@ -659 +659 @@
                     AssertMsgFailed(("Invalid handle!!!!\n"));
                     rc = VERR_INVALID_HANDLE;
+                }
+                else if (flags & SHFL_LOCK_WAIT)
+                {
+                    /* @todo This should be properly implemented by the shared folders service.
+                     *       The service thread must never block. If an operation requires
+                     *       blocking, it must be processed by another thread and when it is
+                     *       completed, the another thread must call
+                     *
+                     *           g_pHelpers->pfnCallComplete (callHandle, rc);
+                     */
+
+                    /* Operation is async. */
+                    fAsynchronousProcessing = true;
+
+                    /* Here the operation must be posted to another thread. At the moment it is not implemented. */
+                    rc = VERR_NOT_SUPPORTED;
                 }
                 else
@@ -1059 +1075 @@
     LogFlow(("svcCall: rc = %Vrc\n", rc));
 
-    if (!AsynchronousProcessing)
+    if (   !fAsynchronousProcessing
+        || VBOX_FAILURE (rc))
     {
+        /* Complete the operation if it was unsuccessful or 
+         * it was processed synchronously.
+         */
         g_pHelpers->pfnCallComplete (callHandle, rc);
     }