Changeset 78726 in vbox for trunk/src/VBox/ValidationKit

Timestamp:

May 24, 2019 1:20:21 PM (6 years ago)

Author:

vboxsync

Message:

vsheriff: Correctly identify GA and serial port tests and pass them to investigateVBoxVMTest. Added --testset option for targetly testing changes against a few specific testsets. Don't stop looking on ktReason_Unknown_VM_Start_Error as we might get better match when going over the hardening log, for instance.

File:

• trunk/src/VBox/ValidationKit/testmanager/batch/virtual_test_sheriff.py (modified) (6 diffs)

trunk/src/VBox/ValidationKit/testmanager/batch/virtual_test_sheriff.py

@@ -172 +172 @@
         """ Test case classification: VirtualBox Guest Additions test. """
         return self.isVBoxTest() \
-           and self.oTestCase.sName.lower().startswith('ga\'s tests');
+           and (   self.oTestCase.sName.lower().startswith('guest additions')
+                or self.oTestCase.sName.lower().startswith('ga\'s tests'));
 
     def isVBoxAPITest(self):
@@ -188 +189 @@
         return self.isVBoxTest() \
            and self.oTestCase.sName.lower().startswith('smoketest');
+
+    def isVBoxSerialTest(self):
+        """ Test case classification: Smoke test. """
+        return self.isVBoxTest() \
+           and self.oTestCase.sName.lower().startswith('serial:');
 
 
@@ -300 +306 @@
         oParser.add_option('--real-run-back', dest = 'fRealRun', action = 'store_true', default = False,
                            help = 'Whether to commit the findings to the database. Default is a dry run.');
+        oParser.add_option('--testset', dest = 'aidTestSets', metavar = '<id>', default = [], type = 'int', action = 'append',
+                           help = 'Only investigate this one.  Accumulates IDs when repeated.');
         oParser.add_option('-q', '--quiet', dest = 'fQuiet', action = 'store_true', default = False,
                            help = 'Quiet execution');
@@ -996 +1004 @@
         ( True,  ktReason_OSInstall_Sata_no_BM,                     'PCHS=14128/14134/8224' ),
         ( True,  ktReason_Host_DoubleFreeHeap,                      'double free or corruption' ),
-        ( True,  ktReason_Unknown_VM_Start_Error,                   'VMSetError: ' ),
-        ( True,  ktReason_Unknown_VM_Start_Error,                   'error: failed to open session for' ),
+        ( False, ktReason_Unknown_VM_Start_Error,                   'VMSetError: ' ),
+        ( False, ktReason_Unknown_VM_Start_Error,                   'error: failed to open session for' ),
         ( False, ktReason_Unknown_VM_Runtime_Error,                 'Console: VM runtime error: fatal=true' ),
     ];
@@ -1377 +1385 @@
         #
         cGot = 0;
-        aoTestSets = self.oTestSetLogic.fetchFailedSetsWithoutReason(cHoursBack = self.oConfig.cHoursBack, tsNow = self.tsNow);
+        if self.oConfig.aidTestSets is None or len(self.oConfig.aidTestSets) == 0:
+            aoTestSets = self.oTestSetLogic.fetchFailedSetsWithoutReason(cHoursBack = self.oConfig.cHoursBack,
+                                                                         tsNow = self.tsNow);
+        else:
+            aoTestSets = [self.oTestSetLogic.getById(idTestSet) for idTestSet in self.oConfig.aidTestSets];
         for oTestSet in aoTestSets:
-            self.dprint(u'');
-            self.dprint(u'reasoningFailures: Checking out test set #%u, status %s'  % ( oTestSet.idTestSet, oTestSet.enmStatus,))
+            self.dprint(u'----------------------------------- #%u, status %s -----------------------------------'
+                        % ( oTestSet.idTestSet, oTestSet.enmStatus,));
 
             #
@@ -1426 +1438 @@
 
             elif oCaseFile.isVBoxSmokeTest():
+                self.dprint(u'investigateVBoxVMTest is taking over %s.' % (oCaseFile.sLongName,));
+                fRc = self.investigateVBoxVMTest(oCaseFile, fSingleVM = False);
+
+            elif oCaseFile.isVBoxSerialTest():
                 self.dprint(u'investigateVBoxVMTest is taking over %s.' % (oCaseFile.sLongName,));
                 fRc = self.investigateVBoxVMTest(oCaseFile, fSingleVM = False);