Changeset 78745 in vbox for trunk/src

Timestamp:

May 25, 2019 2:22:39 PM (6 years ago)

Author:

vboxsync

Message:

Main/GuestDnD: Moved up comment about dragons and set pTask to NULL for emphasis.

Location:

trunk/src/VBox/Main/src-client

Files:

• GuestDnDSourceImpl.cpp (modified) (2 diffs)
• GuestDnDTargetImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-client/GuestDnDSourceImpl.cpp

@@ -378 +378 @@
          * so there is no need in the call of delete operator. */
         hr = pTask->createThreadWithType(RTTHREADTYPE_MAIN_WORKER);
-
+        pTask = NULL;  /* Note: pTask is now owned by the worker thread. */
     }
     catch (std::bad_alloc &)
@@ -397 +397 @@
         ComAssertComRC(hr);
 
-        /* Note: pTask is now owned by the worker thread. */
     }
     else

trunk/src/VBox/Main/src-client/GuestDnDTargetImpl.cpp

@@ -659 +659 @@
          * so there is no need in the call of delete operator. */
         hr = pTask->createThreadWithType(RTTHREADTYPE_MAIN_WORKER);
-
+        pTask = NULL; /* Note: pTask is now owned by the worker thread. */
     }
     catch (std::bad_alloc &)
@@ -677 +677 @@
         hr = pResp->queryProgressTo(aProgress.asOutParam());
         ComAssertComRC(hr);
-
-        /* Note: pTask is now owned by the worker thread. */
     }
     else