Changeset 78761 in vbox for trunk/src/VBox/Main/include

Timestamp:

May 26, 2019 4:31:12 AM (6 years ago)

Author:

vboxsync

Message:

Main/Machine::moveTo: Some cleanups and a lot of @todo's. bugref:8345

File:

• trunk/src/VBox/Main/include/MachineImplMoveVM.h (modified) (4 diffs)

trunk/src/VBox/Main/include/MachineImplMoveVM.h

@@ -68 +68 @@
     struct ErrorInfoItem
     {
-        ErrorInfoItem(HRESULT aCode, const char* aDescription):
-            m_code(aCode),
-            m_description(aDescription == NULL ? "There is no description" : aDescription)
+        ErrorInfoItem(HRESULT aCode, const char* aDescription)
+            : m_code(aCode)
+            , m_description(aDescription == NULL ? "There is no description" : aDescription)
         {
         }
@@ -80 +80 @@
     };
 
-    RTCList<MEDIUMTASKCHAINMOVE>    llMedias;
-    RTCList<SAVESTATETASKMOVE>      llSaveStateFiles;
-    std::map<Utf8Str, MEDIUMTASKMOVE>     finalMediumsMap;
-    std::map<Utf8Str, SAVESTATETASKMOVE>  finalSaveStateFilesMap;
-    std::map<VBoxFolder_t, Utf8Str> vmFolders;
-    std::list<ErrorInfoItem> errorsList;
+    /** @todo r=bird: Why no m_ prefixes here? */
+    RTCList<MEDIUMTASKCHAINMOVE>            llMedias;
+    RTCList<SAVESTATETASKMOVE>              llSaveStateFiles;
+    std::map<Utf8Str, MEDIUMTASKMOVE>       finalMediumsMap;
+    std::map<Utf8Str, SAVESTATETASKMOVE>    finalSaveStateFilesMap;
+    std::map<VBoxFolder_t, Utf8Str>         vmFolders;
+    std::list<ErrorInfoItem>                errorsList;
 
     ComObjPtr<Machine>  m_pMachine;
@@ -94 +95 @@
     Utf8Str             m_targetPath;
     Utf8Str             m_type;
-    HRESULT             result;
+    HRESULT             result; /**< @todo r=bird: Why no m_ prefix here?    */
 
 public:
@@ -101 +102 @@
                   const com::Utf8Str &aType,
                   ComObjPtr<Progress> &aProgress)
-      : ThreadTask("TaskMoveVM"),
-        m_pMachine(aMachine),
-        m_pProgress(aProgress),
-        m_targetPath(aTargetPath),
-        m_type (aType.isEmpty() == true ? "basic" : aType),
-        result(S_OK)
+        : ThreadTask("TaskMoveVM")
+        , m_pMachine(aMachine)
+        , m_pProgress(aProgress)
+        , m_targetPath(aTargetPath)
+        , m_type(aType.isEmpty() ? "basic" : aType)
+        , result(S_OK)
     {
     }