Changeset 78778 in vbox for trunk/src/VBox/Frontends/VirtualBox

Timestamp:

May 27, 2019 10:08:59 AM (6 years ago)

Author:

vboxsync

Message:

FE/Qt: stop checking for spontaneous resize events.
bugref:9454: FE/Qt: Ubuntu 19.04, mouse-drag resize events not always spontaneous()
ticketref:18677: Can-t Resize display in virtualbox guest
We currently check resize events for spontaneous or not, which is Qt-s way of
telling us whether they came from the window system or not, and as an added
precaution against resize loops only pass them to the guest if they are
spontaneous. The thinking is that un-spontaneous events will have been
triggered by the guest, so no need to notify about them. However, on
Xwayland with client-side decorations Qt does the window manager-s job
itself on the client side and sends the resize events itself, without
labeling them as spontaneous, and breaking our logic.
So: this change drops the check, and hopefully other checks which are still
in place should be enough.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/runtime/normal/UIMachineViewNormal.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/normal/UIMachineViewNormal.cpp

@@ -69 +69 @@
                 setMaxGuestSize();
                 /* And resize guest to current window size: */
-                if (pEvent->spontaneous() && m_bIsGuestAutoresizeEnabled && uisession()->isGuestSupportsGraphics())
+                if (m_bIsGuestAutoresizeEnabled && uisession()->isGuestSupportsGraphics())
                     QTimer::singleShot(300, this, SLOT(sltPerformGuestResize()));
                 break;