Changeset 78790 in vbox for trunk/src

Timestamp:

May 27, 2019 7:07:49 PM (6 years ago)

Author:

vboxsync

Message:

GuestHost/OpenGL/state_tracker/state_lighting.c: Fixed parameter validation, Make sure only the GL_SHININESS gets accepted for glMaterialf() glMateriali() as per specification

File:

• trunk/src/VBox/GuestHost/OpenGL/state_tracker/state_lighting.c (modified) (1 diff)

trunk/src/VBox/GuestHost/OpenGL/state_tracker/state_lighting.c

@@ -737 +737 @@
 void STATE_APIENTRY crStateMaterialf (PCRStateTracker pState, GLenum face, GLenum pname, GLfloat param)
 {
-        crStateMaterialfv(pState, face, pname, &param);
+    if (pname != GL_SHININESS)
+    {
+        crStateError(pState, __LINE__, __FILE__, GL_INVALID_ENUM, "crStateMaterialf: bad pname: 0x%x", pname);
+        return;
+    }
+    crStateMaterialfv(pState, face, pname, &param);
 }
 
 void STATE_APIENTRY crStateMateriali (PCRStateTracker pState, GLenum face, GLenum pname, GLint param)
 {
-        GLfloat f_param = (GLfloat) param;
-        crStateMaterialfv(pState, face, pname, &f_param);
+    GLfloat f_param = (GLfloat) param;
+
+    if (pname != GL_SHININESS)
+    {
+        crStateError(pState, __LINE__, __FILE__, GL_INVALID_ENUM, "crStateMateriali: bad pname: 0x%x", pname);
+        return;
+    }
+
+    crStateMaterialfv(pState, face, pname, &f_param);
 }