VirtualBox

Ignore:
Timestamp:
Jun 11, 2019 11:58:28 AM (6 years ago)
Author:
vboxsync
svn:sync-xref-src-repo-rev:
131247
Message:

ValKit: New pylint version - cleanup in progress.

Location:
trunk/src/VBox/ValidationKit/testmanager/core
Files:
25 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/VBox/ValidationKit/testmanager/core/base.py

    r76553 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55"""
    … …  
    4444# Python 3 hacks:
    4545if sys.version_info[0] >= 3:
    46     long = int      # pylint: disable=W0622,C0103
     46    long = int      # pylint: disable=redefined-builtin,invalid-name
    4747
    4848
    … …  
    5151    For exceptions raised by any TestManager component.
    5252    """
    53     pass;
     53    pass;                               # pylint: disable=unnecessary-pass
    5454
    5555
    … …  
    5959    Used by ModelLogicBase decendants.
    6060    """
    61     pass;
     61    pass;                               # pylint: disable=unnecessary-pass
    6262
    6363
    … …  
    6767    Used by ModelLogicBase decendants.
    6868    """
    69     pass;
     69    pass;                               # pylint: disable=unnecessary-pass
    7070
    7171
    … …  
    7575    Used by ModelLogicBase decendants.
    7676    """
    77     pass;
     77    pass;                               # pylint: disable=unnecessary-pass
    7878
    7979
    … …  
    8383    Used by ModelLogicBase decendants.
    8484    """
    85     pass;
     85    pass;                               # pylint: disable=unnecessary-pass
    8686
    8787
    … …  
    9191    Used by ModelLogicBase decendants.
    9292    """
    93     pass;
     93    pass;                               # pylint: disable=unnecessary-pass
    9494
    9595
    … …  
    100100    Used by ModelLogicBase decendants.
    101101    """
    102     pass;
    103 
    104 
    105 class ModelBase(object): # pylint: disable=R0903
     102    pass;                               # pylint: disable=unnecessary-pass
     103
     104
     105class ModelBase(object): # pylint: disable=too-few-public-methods
    106106    """
    107107    Something all classes in the logical model inherits from.
    … …  
    115115
    116116
    117 class ModelDataBase(ModelBase): # pylint: disable=R0903
     117class ModelDataBase(ModelBase): # pylint: disable=too-few-public-methods
    118118    """
    119119    Something all classes in the data classes in the logical model inherits from.
    … …  
    198198        if sPrefix in ['id', 'uid', 'i', 'off', 'pct']:
    199199            return [-1, '', '-1',];
    200         elif sPrefix in ['l', 'c',]:
     200        if sPrefix in ['l', 'c',]:
    201201            return [long(-1), '', '-1',];
    202         elif sPrefix == 'f':
     202        if sPrefix == 'f':
    203203            return ['',];
    204         elif sPrefix in ['enm', 'ip', 's', 'ts', 'uuid']:
     204        if sPrefix in ['enm', 'ip', 's', 'ts', 'uuid']:
    205205            return ['',];
    206         elif sPrefix in ['ai', 'aid', 'al', 'as']:
     206        if sPrefix in ['ai', 'aid', 'al', 'as']:
    207207            return [[], '', None]; ## @todo ??
    208         elif sPrefix == 'bm':
     208        if sPrefix == 'bm':
    209209            return ['', [],]; ## @todo bitmaps.
    210210        raise TMExceptionBase('Unable to classify "%s" (prefix %s)' % (sAttr, sPrefix));
    … …  
    370370
    371371        # Check the NULL requirements of the primary ID(s) for the 'add' and 'edit' actions.
    372         if   enmValidateFor == ModelDataBase.ksValidateFor_Add \
    373           or enmValidateFor == ModelDataBase.ksValidateFor_AddForeignId \
    374           or enmValidateFor == ModelDataBase.ksValidateFor_Edit:
     372        if enmValidateFor in (ModelDataBase.ksValidateFor_Add,
     373                              ModelDataBase.ksValidateFor_AddForeignId,
     374                              ModelDataBase.ksValidateFor_Edit,):
    375375            fMustBeNull = enmValidateFor == ModelDataBase.ksValidateFor_Add;
    376376            sAttr = getattr(self, 'ksIdAttr', None);
    … …  
    572572        if iValue < iMin:
    573573            return (iValue, 'Value too small (min %d)' % (iMin,));
    574         elif iValue > iMax:
     574        if iValue > iMax:
    575575            return (iValue, 'Value too high (max %d)' % (iMax,));
    576576        return (iValue, None);
    … …  
    596596        if lMin is not None and lValue < lMin:
    597597            return (lValue, 'Value too small (min %d)' % (lMin,));
    598         elif lMax is not None and lValue > lMax:
     598        if lMax is not None and lValue > lMax:
    599599            return (lValue, 'Value too high (max %d)' % (lMax,));
    600600        return (lValue, None);
    … …  
    662662
    663663        try:
    664             socket.inet_pton(socket.AF_INET, sValue); # pylint: disable=E1101
     664            socket.inet_pton(socket.AF_INET, sValue); # pylint: disable=no-member
    665665        except:
    666666            try:
    667                 socket.inet_pton(socket.AF_INET6, sValue); # pylint: disable=E1101
     667                socket.inet_pton(socket.AF_INET6, sValue); # pylint: disable=no-member
    668668            except:
    669669                return (sValue, 'Not a valid IP address.');
    … …  
    10671067
    10681068
    1069 # pylint: disable=E1101,C0111,R0903
     1069# pylint: disable=no-member,missing-docstring,too-few-public-methods
    10701070class ModelDataBaseTestCase(unittest.TestCase):
    10711071    """
    … …  
    12411241    def __init__(self):
    12421242        ModelBase.__init__(self);
    1243         self.aCriteria = []; # type: list[FilterCriterion]
     1243        self.aCriteria = [] # type: list[FilterCriterion]
    12441244
    12451245    def _initFromParamsWorker(self, oDisp, oCriterion):
    … …  
    12851285
    12861286
    1287 class ModelLogicBase(ModelBase): # pylint: disable=R0903
     1287class ModelLogicBase(ModelBase): # pylint: disable=too-few-public-methods
    12881288    """
    12891289    Something all classes in the logic classes the logical model inherits from.
    … …  
    13281328
    13291329
    1330 class AttributeChangeEntry(object): # pylint: disable=R0903
     1330class AttributeChangeEntry(object): # pylint: disable=too-few-public-methods
    13311331    """
    13321332    Data class representing the changes made to one attribute.
    … …  
    13401340        self.sOldText       = sOldText;
    13411341
    1342 class AttributeChangeEntryPre(AttributeChangeEntry): # pylint: disable=R0903
     1342class AttributeChangeEntryPre(AttributeChangeEntry): # pylint: disable=too-few-public-methods
    13431343    """
    13441344    AttributeChangeEntry for preformatted values.
    … …  
    13481348        AttributeChangeEntry.__init__(self, sAttr, oNewRaw, oOldRaw, sNewText, sOldText);
    13491349
    1350 class ChangeLogEntry(object): # pylint: disable=R0903
     1350class ChangeLogEntry(object): # pylint: disable=too-few-public-methods
    13511351    """
    13521352    A change log entry returned by the fetchChangeLog method typically

  • trunk/src/VBox/ValidationKit/testmanager/core/build.py

    r76553 r79087  
    143143
    144144
    145 class BuildCategoryLogic(ModelLogicBase): # pylint: disable=R0903
     145class BuildCategoryLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    146146    """
    147147    Build categories database logic.
    … …  
    502502
    503503
    504 class BuildLogic(ModelLogicBase): # pylint: disable=R0903
     504class BuildLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    505505    """
    506506    Build database logic (covers build categories as well as builds).
    … …  
    867867#
    868868
    869 # pylint: disable=C0111
     869# pylint: disable=missing-docstring
    870870class BuildCategoryDataTestCase(ModelDataBaseTestCase):
    871871    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/buildblacklist.py

    r76553 r79087  
    119119
    120120
    121 class BuildBlacklistLogic(ModelLogicBase): # pylint: disable=R0903
     121class BuildBlacklistLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    122122    """
    123123    Build Back List logic.

  • trunk/src/VBox/ValidationKit/testmanager/core/buildsource.py

    r76553 r79087  
    150150        return (oNewValue, sError);
    151151
    152 class BuildSourceLogic(ModelLogicBase): # pylint: disable=R0903
     152class BuildSourceLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    153153    """
    154154    Build source database logic.
    … …  
    504504#
    505505
    506 # pylint: disable=C0111
     506# pylint: disable=missing-docstring
    507507class BuildSourceDataTestCase(ModelDataBaseTestCase):
    508508    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/db.py

    r76553 r79087  
    214214        if config.g_ksDatabasePort is not None:
    215215            dArgs['port'] = config.g_ksDatabasePort;
    216         self._oConn             = psycopg2.connect(**dArgs); # pylint: disable=W0142
     216        self._oConn             = psycopg2.connect(**dArgs); # pylint: disable=star-args
    217217        self._oConn.set_client_encoding('UTF-8');
    218218        self._oCursor           = self._oConn.cursor();
    … …  
    220220        self._oExplainCursor    = None;
    221221        if config.g_kfWebUiSqlTraceExplain and config.g_kfWebUiSqlTrace:
    222             self._oExplainConn  = psycopg2.connect(**dArgs); # pylint: disable=W0142
     222            self._oExplainConn  = psycopg2.connect(**dArgs); # pylint: disable=star-args
    223223            self._oExplainConn.set_client_encoding('UTF-8');
    224224            self._oExplainCursor = self._oExplainConn.cursor();
    … …  
    701701            if config.g_ksDatabasePort is not None:
    702702                dArgs['port'] = config.g_ksDatabasePort;
    703             self._oExplainConn  = psycopg2.connect(**dArgs); # pylint: disable=W0142
     703            self._oExplainConn  = psycopg2.connect(**dArgs); # pylint: disable=star-args
    704704            self._oExplainCursor = self._oExplainConn.cursor();
    705705        return True;

  • trunk/src/VBox/ValidationKit/testmanager/core/failurecategory.py

    r76553 r79087  
    109109
    110110
    111 class FailureCategoryLogic(ModelLogicBase): # pylint: disable=R0903
     111class FailureCategoryLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    112112    """
    113113    Failure Category logic.
    … …  
    149149
    150150
    151     def fetchForChangeLog(self, idFailureCategory, iStart, cMaxRows, tsNow): # pylint: disable=R0914
     151    def fetchForChangeLog(self, idFailureCategory, iStart, cMaxRows, tsNow): # pylint: disable=too-many-locals
    152152        """
    153153        Fetches change log entries for a failure reason.

  • trunk/src/VBox/ValidationKit/testmanager/core/failurereason.py

    r76553 r79087  
    143143
    144144
    145 class FailureReasonLogic(ModelLogicBase): # pylint: disable=R0903
     145class FailureReasonLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    146146    """
    147147    Failure Reason logic.
    … …  
    276276
    277277
    278     def fetchForChangeLog(self, idFailureReason, iStart, cMaxRows, tsNow): # pylint: disable=R0914
     278    def fetchForChangeLog(self, idFailureReason, iStart, cMaxRows, tsNow): # pylint: disable=too-many-locals
    279279        """
    280280        Fetches change log entries for a failure reason.

  • trunk/src/VBox/ValidationKit/testmanager/core/globalresource.py

    r76553 r79087  
    308308#
    309309
    310 # pylint: disable=C0111
     310# pylint: disable=missing-docstring
    311311class GlobalResourceDataTestCase(ModelDataBaseTestCase):
    312312    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/report.py

    r76553 r79087  
    6060
    6161
    62 class ReportModelBase(ModelLogicBase): # pylint: disable=R0903
     62class ReportModelBase(ModelLogicBase): # pylint: disable=too-few-public-methods
    6363    """
    6464    Something all report logic(/miner) classes inherit from.
    … …  
    242242class ReportFailureReasonTransient(ReportTransientBase):
    243243    """ Details on the test where a failure reason was first/last seen.  """
    244     def __init__(self, idBuild, iRevision, sRepository, idTestSet, idTestResult, tsDone,  # pylint: disable=R0913
     244    def __init__(self, idBuild, iRevision, sRepository, idTestSet, idTestResult, tsDone,  # pylint: disable=too-many-arguments
    245245                 iPeriod, fEnter, oReason):
    246246        ReportTransientBase.__init__(self, idBuild, iRevision, sRepository, idTestSet, idTestResult, tsDone, iPeriod, fEnter,
    … …  
    530530
    531531
    532 class ReportLazyModel(ReportModelBase): # pylint: disable=R0903
     532class ReportLazyModel(ReportModelBase): # pylint: disable=too-few-public-methods
    533533    """
    534534    The 'lazy bird' report model class.
    … …  
    890890
    891891
    892 class ReportGraphModel(ReportModelBase): # pylint: disable=R0903
     892class ReportGraphModel(ReportModelBase): # pylint: disable=too-few-public-methods
    893893    """
    894894    Extended report model used when generating the more complicated graphs
    … …  
    977977
    978978
    979     def __init__(self, oDb, tsNow, cPeriods, cHoursPerPeriod, sSubject, aidSubjects, # pylint: disable=R0913
     979    def __init__(self, oDb, tsNow, cPeriods, cHoursPerPeriod, sSubject, aidSubjects, # pylint: disable=too-many-arguments
    980980                 aidTestBoxes, aidBuildCats, aidTestCases, fSepTestVars):
    981981        assert(sSubject == self.ksSubEverything); # dummy

  • trunk/src/VBox/ValidationKit/testmanager/core/schedgroup.py

    r76553 r79087  
    259259    def __init__(self):
    260260        SchedGroupData.__init__(self);
    261         self.aoMembers          = [];       # type: SchedGroupMemberDataEx
     261        self.aoMembers          = []        # type: SchedGroupMemberDataEx
    262262
    263263        # Two build sources for convenience sake.
    264         self.oBuildSrc          = None;     # type: TestBoxData
    265         self.oBuildSrcValidationKit = None; # type: TestBoxData
     264        self.oBuildSrc          = None      # type: TestBoxData
     265        self.oBuildSrcValidationKit = None  # type: TestBoxData
    266266        # List of test boxes that uses this group for convenience.
    267         self.aoTestBoxes        = None;     # type: list[TestBoxData]
     267        self.aoTestBoxes        = None      # type: list[TestBoxData]
    268268
    269269    def _initExtraMembersFromDb(self, oDb, tsNow = None, sPeriodBack = None):
    … …  
    421421
    422422
    423 class SchedGroupLogic(ModelLogicBase): # pylint: disable=R0903
     423class SchedGroupLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    424424    """
    425425    SchedGroup logic.
    … …  
    578578                raise TMRowInUse('Scheduling group #%d is associated with one or more test boxes: %s'
    579579                                 % (idSchedGroup, ', '.join(asTestBoxes),));
    580             else:
    581                 # Reassign testboxes to scheduling group #1 (the default group).
    582                 oTbLogic = TestBoxLogic(self._oDb);
    583                 for oTestBox in oData.aoTestBoxes:
    584                     oTbCopy = TestBoxData().initFromOther(oTestBox);
    585                     oTbCopy.idSchedGroup = 1;
    586                     oTbLogic.editEntry(oTbCopy, uidAuthor, fCommit = False);
    587 
    588                 oData = SchedGroupDataEx().initFromDbWithId(self._oDb, idSchedGroup);
    589                 if oData.aoTestBoxes:
    590                     raise TMRowInUse('More testboxes was added to the scheduling group as we were trying to delete it.');
     580            # Reassign testboxes to scheduling group #1 (the default group).
     581            oTbLogic = TestBoxLogic(self._oDb);
     582            for oTestBox in oData.aoTestBoxes:
     583                oTbCopy = TestBoxData().initFromOther(oTestBox);
     584                oTbCopy.idSchedGroup = 1;
     585                oTbLogic.editEntry(oTbCopy, uidAuthor, fCommit = False);
     586
     587            oData = SchedGroupDataEx().initFromDbWithId(self._oDb, idSchedGroup);
     588            if oData.aoTestBoxes:
     589                raise TMRowInUse('More testboxes was added to the scheduling group as we were trying to delete it.');
    591590
    592591        #
    … …  
    982981#
    983982
    984 # pylint: disable=C0111
     983# pylint: disable=missing-docstring
    985984class SchedGroupMemberDataTestCase(ModelDataBaseTestCase):
    986985    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/schedulerbase.py

    r76553 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55
    … …  
    352352        self.cMissingGangMembers    = 1;
    353353
    354     def initFromValues(self, idSchedGroup, idGenTestCaseArgs, idTestGroup, aidTestGroupPreReqs, # pylint: disable=R0913
     354    def initFromValues(self, idSchedGroup, idGenTestCaseArgs, idTestGroup, aidTestGroupPreReqs, # pylint: disable=too-many-arguments
    355355                       bmHourlySchedule, cMissingGangMembers,
    356356                       idItem = None, offQueue = None, tsConfig = None, tsLastScheduled = None, idTestSetGangLeader = None):
    … …  
    15061506#
    15071507
    1508 # pylint: disable=C0111
     1508# pylint: disable=missing-docstring
    15091509class SchedQueueDataTestCase(ModelDataBaseTestCase):
    15101510    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/schedulerbeci.py

    r76553 r79087  
    3434
    3535
    36 class SchdulerBeci(SchedulerBase): # pylint: disable=R0903
     36class SchdulerBeci(SchedulerBase): # pylint: disable=too-few-public-methods
    3737    """
    3838    The best-effort-continuous-integration scheduler, BECI for short.

  • trunk/src/VBox/ValidationKit/testmanager/core/systemchangelog.py

    r76553 r79087  
    3636
    3737
    38 class SystemChangelogEntry(object): # pylint: disable=R0902
     38class SystemChangelogEntry(object): # pylint: disable=too-many-instance-attributes
    3939    """
    4040    System changelog entry.
    … …  
    7171
    7272    ## Mapping a changelog entry kind to a table, key and clue.
    73     kdWhatToTable = dict({  # pylint: disable=W0142
     73    kdWhatToTable = dict({  # pylint: disable=star-args
    7474        ksWhat_TestBox:          ( 'TestBoxes',          'idTestBox',           None, ),
    7575        ksWhat_TestCase:         ( 'TestCasees',         'idTestCase',          None, ),

  • trunk/src/VBox/ValidationKit/testmanager/core/systemlog.py

    r76553 r79087  
    3737
    3838
    39 class SystemLogData(ModelDataBase):  # pylint: disable=R0902
     39class SystemLogData(ModelDataBase):  # pylint: disable=too-many-instance-attributes
    4040    """
    4141    SystemLog Data.
    … …  
    166166#
    167167
    168 # pylint: disable=C0111
     168# pylint: disable=missing-docstring
    169169class SystemLogDataTestCase(ModelDataBaseTestCase):
    170170    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/testbox.py

    r76886 r79087  
    9999    def __init__(self):
    100100        TestBoxInSchedGroupData.__init__(self);
    101         self.oSchedGroup        = None; # type: SchedGroupData
     101        self.oSchedGroup        = None  # type: SchedGroupData
    102102
    103103    def initFromDbRowEx(self, aoRow, oDb, tsNow = None, sPeriodBack = None):
    … …  
    111111
    112112
    113 # pylint: disable=C0103
    114 class TestBoxData(ModelDataBase):  # pylint: disable=R0902
     113# pylint: disable=invalid-name
     114class TestBoxData(ModelDataBase):  # pylint: disable=too-many-instance-attributes
    115115    """
    116116    TestBox Data.
    … …  
    476476            if uFam == 0xf:
    477477                if uMod < 0x10:                             return 'K8_130nm';
    478                 if uMod >= 0x60 and uMod < 0x80:            return 'K8_65nm';
     478                if 0x60 <= uMod < 0x80:                     return 'K8_65nm';
    479479                if uMod >= 0x40:                            return 'K8_90nm_AMDV';
    480480                if uMod in [0x21, 0x23, 0x2b, 0x37, 0x3f]:  return 'K8_90nm_DualCore';
    … …  
    567567    def __init__(self):
    568568        TestBoxData.__init__(self);
    569         self.aoInSchedGroups        = [];   # type: list[TestBoxInSchedGroupData]
     569        self.aoInSchedGroups        = []    # type: list[TestBoxInSchedGroupData]
    570570
    571571    def _initExtraMembersFromDb(self, oDb, tsNow = None, sPeriodBack = None):
    … …  
    634634        return aoNewValues;
    635635
    636     def _validateAndConvertAttribute(self, sAttr, sParam, oValue, aoNilValues, fAllowNull, oDb): # pylint: disable=R0914
     636    def _validateAndConvertAttribute(self, sAttr, sParam, oValue, aoNilValues, fAllowNull, oDb): # pylint: disable=too-many-locals
    637637        """
    638638        Validate special arrays and requirement expressions.
    … …  
    773773                TestBoxDataEx.__init__(self);
    774774                self.tsCurrent = None;  # CURRENT_TIMESTAMP
    775                 self.oStatus   = None;  # type: TestBoxStatusData
     775                self.oStatus   = None   # type: TestBoxStatusData
    776776
    777777        from testmanager.core.testboxstatus import TestBoxStatusData;
    … …  
    811811        return aoRows;
    812812
    813     def fetchForChangeLog(self, idTestBox, iStart, cMaxRows, tsNow): # pylint: disable=R0914
     813    def fetchForChangeLog(self, idTestBox, iStart, cMaxRows, tsNow): # pylint: disable=too-many-locals
    814814        """
    815815        Fetches change log entries for a testbox.
    … …  
    10131013
    10141014
    1015     def updateOnSignOn(self, idTestBox, idGenTestBox, sTestBoxAddr, sOs, sOsVersion, # pylint: disable=R0913,R0914
     1015    def updateOnSignOn(self, idTestBox, idGenTestBox, sTestBoxAddr, sOs, sOsVersion, # pylint: disable=too-many-arguments,too-many-locals
    10161016                       sCpuVendor, sCpuArch, sCpuName, lCpuRevision, cCpus, fCpuHwVirt, fCpuNestedPaging, fCpu64BitGuest,
    10171017                       fChipsetIoMmu, fRawMode, cMbMemory, cMbScratch, sReport, iTestBoxScriptRev, iPythonHexVersion):
    … …  
    11531153        except TMInFligthCollision:
    11541154            return False;
    1155         except:
    1156             raise;
    11571155        return True;
    11581156
    … …  
    11771175#
    11781176
    1179 # pylint: disable=C0111
     1177# pylint: disable=missing-docstring
    11801178class TestBoxDataTestCase(ModelDataBaseTestCase):
    11811179    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/testboxcontroller.py

    r76553 r79087  
    3333import re;
    3434import os;
    35 import string;                          # pylint: disable=W0402
     35import string;                          # pylint: disable=deprecated-module
    3636import sys;
    3737import uuid;
    … …  
    5353# Python 3 hacks:
    5454if sys.version_info[0] >= 3:
    55     long = int;     # pylint: disable=W0622,C0103
     55    long = int;     # pylint: disable=redefined-builtin,invalid-name
    5656
    5757
    … …  
    6060    Exception class for TestBoxController.
    6161    """
    62     pass;
    63 
    64 
    65 class TestBoxController(object): # pylint: disable=R0903
     62    pass;                               # pylint: disable=unnecessary-pass
     63
     64
     65class TestBoxController(object): # pylint: disable=too-few-public-methods
    6666    """
    6767    TestBox Controller class.
    … …  
    190190        """
    191191        sValue = self._getStringParam(sName, [ 'True', 'true', '1', 'False', 'false', '0'], sDefValue = str(fDefValue));
    192         return sValue == 'True' or sValue == 'true' or sValue == '1';
     192        return sValue in ('True', 'true', '1',);
    193193
    194194    def _getIntParam(self, sName, iMin = None, iMax = None):
    … …  
    346346        return fSizeOk;
    347347
    348     def _actionSignOn(self):        # pylint: disable=R0914
     348    def _actionSignOn(self):        # pylint: disable=too-many-locals
    349349        """ Implement sign-on """
    350350
    … …  
    401401            cPctScratchDiff = 100;
    402402
    403         # pylint: disable=R0916
     403        # pylint: disable=too-many-boolean-expressions
    404404        if   self._sTestBoxAddr != oTestBox.ip \
    405405          or sOs                != oTestBox.sOs \
    … …  
    738738
    739739            abBuf = oSrcFile.read(cbToRead);
    740             oDstFile.write(abBuf); # pylint: disable=E1103
     740            oDstFile.write(abBuf); # pylint: disable=maybe-no-member
    741741            del abBuf;
    742742
    743         oDstFile.close(); # pylint: disable=E1103
     743        oDstFile.close(); # pylint: disable=maybe-no-member
    744744
    745745        # Done.

  • trunk/src/VBox/ValidationKit/testmanager/core/testboxstatus.py

    r76553 r79087  
    297297#
    298298
    299 # pylint: disable=C0111
     299# pylint: disable=missing-docstring
    300300class TestBoxStatusDataTestCase(ModelDataBaseTestCase):
    301301    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/testcase.py

    r76553 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55"""
    … …  
    857857        return aoNewValues;
    858858
    859     def _validateAndConvertAttribute(self, sAttr, sParam, oValue, aoNilValues, fAllowNull, oDb): # pylint: disable=R0914
     859    def _validateAndConvertAttribute(self, sAttr, sParam, oValue, aoNilValues, fAllowNull, oDb): # pylint: disable=too-many-locals
    860860        """
    861861        Validate special arrays and requirement expressions.
    … …  
    999999        return aoRows;
    10001000
    1001     def fetchForChangeLog(self, idTestCase, iStart, cMaxRows, tsNow): # pylint: disable=R0914
     1001    def fetchForChangeLog(self, idTestCase, iStart, cMaxRows, tsNow): # pylint: disable=too-many-locals
    10021002        """
    10031003        Fetches change log entries for a testbox.
    … …  
    11841184        return True;
    11851185
    1186     def editEntry(self, oData, uidAuthor, fCommit = False):  # pylint: disable=R0914
     1186    def editEntry(self, oData, uidAuthor, fCommit = False):  # pylint: disable=too-many-locals
    11871187        """
    11881188        Edit a testcase entry (extended).
    … …  
    14161416#
    14171417
    1418 # pylint: disable=C0111
     1418# pylint: disable=missing-docstring
    14191419class TestCaseGlobalRsrcDepDataTestCase(ModelDataBaseTestCase):
    14201420    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/testcaseargs.py

    r76553 r79087  
    4242# Python 3 hacks:
    4343if sys.version_info[0] >= 3:
    44     long = int;     # pylint: disable=W0622,C0103
     44    long = int;     # pylint: disable=redefined-builtin,invalid-name
    4545
    4646
    … …  
    135135        return self.initFromDbRow(oDb.fetchOne());
    136136
    137     def initFromValues(self, sArgs, cSecTimeout = None, sTestBoxReqExpr = None, sBuildReqExpr = None,  # pylint: disable=R0913
     137    def initFromValues(self, sArgs, cSecTimeout = None, sTestBoxReqExpr = None, sBuildReqExpr = None,  # pylint: disable=too-many-arguments
    138138                       cGangMembers = 1, idTestCase = None, idTestCaseArgs = None, tsEffective = None, tsExpire = None,
    139139                       uidAuthor = None, idGenTestCaseArgs = None, sSubName = None):
    … …  
    396396#
    397397
    398 # pylint: disable=C0111
     398# pylint: disable=missing-docstring
    399399class TestCaseArgsDataTestCase(ModelDataBaseTestCase):
    400400    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/testgroup.py

    r76553 r79087  
    747747#
    748748
    749 # pylint: disable=C0111
     749# pylint: disable=missing-docstring
    750750class TestGroupMemberDataTestCase(ModelDataBaseTestCase):
    751751    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/testresultfailures.py

    r76553 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55## @todo Rename this file to testresult.py!
    … …  
    146146
    147147
    148 class TestResultListingData(ModelDataBase): # pylint: disable=R0902
     148class TestResultListingData(ModelDataBase): # pylint: disable=too-many-instance-attributes
    149149    """
    150150    Test case result data representation for table listing
    … …  
    255255
    256256
    257 class TestResultFailureLogic(ModelLogicBase): # pylint: disable=R0903
     257class TestResultFailureLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    258258    """
    259259    Test result failure reason logic.
    … …  
    263263        ModelLogicBase.__init__(self, oDb)
    264264
    265     def fetchForChangeLog(self, idTestResult, iStart, cMaxRows, tsNow): # pylint: disable=R0914
     265    def fetchForChangeLog(self, idTestResult, iStart, cMaxRows, tsNow): # pylint: disable=too-many-locals
    266266        """
    267267        Fetches change log entries for a failure reason.
    … …  
    509509#
    510510
    511 # pylint: disable=C0111
     511# pylint: disable=missing-docstring
    512512class TestResultFailureDataTestCase(ModelDataBaseTestCase):
    513513    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/testresults.py

    r76553 r79087  
    11# -*- coding: utf-8 -*-
    22# $Id$
    3 # pylint: disable=C0302
     3# pylint: disable=too-many-lines
    44
    55## @todo Rename this file to testresult.py!
    … …  
    550550
    551551
    552 class TestResultListingData(ModelDataBase): # pylint: disable=R0902
     552class TestResultListingData(ModelDataBase): # pylint: disable=too-many-instance-attributes
    553553    """
    554554    Test case result data representation for table listing
    … …  
    990990
    991991
    992 class TestResultLogic(ModelLogicBase): # pylint: disable=R0903
     992class TestResultLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    993993    """
    994994    Results grouped by scheduling group.
    … …  
    11991199        return sRet
    12001200
    1201     def fetchResultsForListing(self, iStart, cMaxRows, tsNow, sInterval, oFilter, enmResultSortBy, # pylint: disable=R0913
     1201    def fetchResultsForListing(self, iStart, cMaxRows, tsNow, sInterval, oFilter, enmResultSortBy, # pylint: disable=too-many-arguments
    12021202                               enmResultsGroupingType, iResultsGroupingValue, fOnlyFailures, fOnlyNeedingReason):
    12031203        """
    … …  
    25582558            if sAttr in dAttribs:
    25592559                try:
    2560                     _ = long(dAttribs[sAttr]);  # pylint: disable=R0204
     2560                    _ = long(dAttribs[sAttr]);  # pylint: disable=redefined-variable-type
    25612561                except:
    25622562                    return 'Element %s has an invalid %s attribute value: %s.' % (sName, sAttr, dAttribs[sAttr],);
    … …  
    28542854#
    28552855
    2856 # pylint: disable=C0111
     2856# pylint: disable=missing-docstring
    28572857class TestResultDataTestCase(ModelDataBaseTestCase):
    28582858    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/testset.py

    r78780 r79087  
    537537        return True;
    538538
    539     def createFile(self, oTestSet, sName, sMime, sKind, sDesc, cbFile, fCommit = False): # pylint: disable=R0914
     539    def createFile(self, oTestSet, sName, sMime, sKind, sDesc, cbFile, fCommit = False): # pylint: disable=too-many-locals
    540540        """
    541541        Creates a file and associating with the current test result record in
    … …  
    825825#
    826826
    827 # pylint: disable=C0111
     827# pylint: disable=missing-docstring
    828828class TestSetDataTestCase(ModelDataBaseTestCase):
    829829    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/useraccount.py

    r76553 r79087  
    282282#
    283283
    284 # pylint: disable=C0111
     284# pylint: disable=missing-docstring
    285285class UserAccountDataTestCase(ModelDataBaseTestCase):
    286286    def setUp(self):

  • trunk/src/VBox/ValidationKit/testmanager/core/vcsrevisions.py

    r76553 r79087  
    105105
    106106
    107 class VcsRevisionLogic(ModelLogicBase): # pylint: disable=R0903
     107class VcsRevisionLogic(ModelLogicBase): # pylint: disable=too-few-public-methods
    108108    """
    109109    VCS revisions database logic.
    … …  
    234234#
    235235
    236 # pylint: disable=C0111
     236# pylint: disable=missing-docstring
    237237class VcsRevisionDataTestCase(ModelDataBaseTestCase):
    238238    def setUp(self):
Note: See TracChangeset for help on using the changeset viewer.

© 2024 Oracle Support Privacy / Do Not Sell My Info Terms of Use Trademark Policy Automated Access Etiquette