Changeset 79092 in vbox for trunk/src/VBox/VMM

Timestamp:

Jun 11, 2019 3:26:40 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

131252

Message:

ValKit,++: Pylint 2.3.1 adjustments.

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllInstructionsPython.py (modified) (11 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllInstructionsPython.py

@@ -621 +621 @@
         self.sSelector      = sSelector;        ##< The member selector, see kdSelectors.
         self.sEncoding      = sEncoding;        ##< The encoding, see kdSelectors.
-        self.aoInstructions = [];               # type: Instruction
+        self.aoInstructions = []                # type: Instruction
         self.sDisParse      = sDisParse;        ##< IDX_ParseXXX.
 
@@ -1278 +1278 @@
 
     def __init__(self, oInstr): # type: (InstructionTest, Instruction)
-        self.oInstr         = oInstr;   # type: InstructionTest
-        self.aoInputs       = [];       # type: list(TestInOut)
-        self.aoOutputs      = [];       # type: list(TestInOut)
-        self.aoSelectors    = [];       # type: list(TestSelector)
+        self.oInstr         = oInstr    # type: InstructionTest
+        self.aoInputs       = []        # type: list(TestInOut)
+        self.aoOutputs      = []        # type: list(TestInOut)
+        self.aoSelectors    = []        # type: list(TestSelector)
 
     def toString(self, fRepr = False):
@@ -1340 +1340 @@
         self.sMnemonic      = None;
         self.sBrief         = None;
-        self.asDescSections = [];       # type: list(str)
-        self.aoMaps         = [];       # type: list(InstructionMap)
-        self.aoOperands     = [];       # type: list(Operand)
+        self.asDescSections = []        # type: list(str)
+        self.aoMaps         = []        # type: list(InstructionMap)
+        self.aoOperands     = []        # type: list(Operand)
         self.sPrefix        = None;     ##< Single prefix: None, 'none', 0x66, 0xf3, 0xf2
-        self.sOpcode        = None;     # type: str
-        self.sSubOpcode     = None;     # type: str
+        self.sOpcode        = None      # type: str
+        self.sSubOpcode     = None      # type: str
         self.sEncoding      = None;
         self.asFlTest       = None;
@@ -1356 +1356 @@
         self.asCpuIds       = [];       ##< The CPUID feature bit names for this instruction. If multiple, assume AND.
         self.asReqFeatures  = [];       ##< Which features are required to be enabled to run this instruction.
-        self.aoTests        = [];       # type: list(InstructionTest)
+        self.aoTests        = []        # type: list(InstructionTest)
         self.sMinCpu        = None;     ##< Indicates the minimum CPU required for the instruction. Not set when oCpuExpr is.
         self.oCpuExpr       = None;     ##< Some CPU restriction expression...
@@ -1426 +1426 @@
         sRet = '<' if fRepr else '';
         for sField, sValue in aasFields:
-            if sValue != None:
+            if sValue is not None:
                 if len(sRet) > 1:
                     sRet += '; ';
@@ -1516 +1516 @@
 
 ## All the instructions.
-g_aoAllInstructions = []; # type: list(Instruction)
+g_aoAllInstructions = []            # type: list(Instruction)
 
 ## All the instructions indexed by statistics name (opstat).
-g_dAllInstructionsByStat = {}; # type: dict(Instruction)
+g_dAllInstructionsByStat = {}       # type: dict(Instruction)
 
 ## All the instructions indexed by function name (opfunction).
-g_dAllInstructionsByFunction = {}; # type: dict(list(Instruction))
+g_dAllInstructionsByFunction = {}   # type: dict(list(Instruction))
 
 ## Instructions tagged by oponlytest
-g_aoOnlyTestInstructions = []; # type: list(Instruction)
+g_aoOnlyTestInstructions = []       # type: list(Instruction)
 
 ## Instruction maps.
@@ -1976 +1976 @@
             return self.errorComment(iTagLine, '%s: value too long (max 180 chars): %s' % (sTag, sBrief));
         offDot = sBrief.find('.');
-        while offDot >= 0 and offDot < len(sBrief) - 1 and sBrief[offDot + 1] != ' ':
+        while 0 <= offDot < len(sBrief) - 1 and sBrief[offDot + 1] != ' ':
             offDot = sBrief.find('.', offDot + 1);
         if offDot >= 0 and offDot != len(sBrief) - 1:
@@ -2042 +2042 @@
         oInstr = self.ensureInstructionForOpTag(iTagLine);
         idxOp = int(sTag[-1]) - 1;
-        assert idxOp >= 0 and idxOp < 4;
+        assert 0 <= idxOp < 4;
 
         # flatten, split up, and validate the "where:type" value.
@@ -2584 +2584 @@
                             self.errorComment(iTagLine, '%s: invalid %s field "%s" in "%s"\nvalid fields: %s'
                                                          % ( sTag, sDesc, sField, sItem,
-                                                             ', '.join([sKey for sKey in TestInOut.kdFields.keys()
+                                                             ', '.join([sKey for sKey in TestInOut.kdFields
                                                                         if TestInOut.kdFields[sKey][1] in asValidFieldKinds]),));
                         break;
@@ -2927 +2927 @@
                 elif ch == chQuote:
                     chQuote = None;
-            elif ch == '"' or ch == '\'':
+            elif ch in ('"', '\'',):
                 chQuote = ch;
-            elif ch == ',' or ch == ')':
+            elif ch in (',', ')',):
                 if cDepth == 1:
                     asRet.append(sInvocation[offStart:off].strip());
@@ -3319 +3319 @@
     except ParserException as oXcpt:
         print(str(oXcpt));
-        raise;
-    except Exception as oXcpt:
         raise;