Changeset 79133 in vbox for trunk/src/VBox/ValidationKit

Timestamp:

Jun 13, 2019 3:27:38 PM (6 years ago)

Author:

vboxsync

Message:

tdAddGuestCtrl.py,Main: Added @todos for incorrect directoryOpen behavior. bugref:9320

File:

• trunk/src/VBox/ValidationKit/tests/additions/tdAddGuestCtrl.py (modified) (2 diffs)

trunk/src/VBox/ValidationKit/tests/additions/tdAddGuestCtrl.py

@@ -1236 +1236 @@
         cOthers  = 0;    # Other files.
 
-        #
+        ##
+        ## @todo r=bird: Unlike fileOpen, directoryOpen will not fail if the directory does not exist.
+        ##       This is of course a bug in the implementation, as it is documented to return
+        ##       VBOX_E_OBJECT_NOT_FOUND or VBOX_E_IPRT_ERROR!
+        ##
+
         # Open the directory:
-        #
-        # Note! Unlike fileOpen, directoryOpen will not fail if the directory does not exist.
-        #       Looks like it won't do nothing till you read from it.
-        #
         #reporter.log2('Directory="%s", filter="%s", fFlags="%s"' % (sCurDir, sFilter, fFlags));
         try:
@@ -1255 +1256 @@
             except Exception as oXcpt:
                 if vbox.ComError.notEqual(oXcpt, vbox.ComError.VBOX_E_OBJECT_NOT_FOUND):
+                    ##
+                    ## @todo r=bird: Change this to reporter.errorXcpt() once directoryOpen() starts
+                    ##       working the way it is documented.
+                    ##
                     reporter.maybeErrXcpt(fIsError, 'Error reading directory "%s":' % (sCurDir,)); # See above why 'maybe'.
                     fRc = False;