Changeset 79223 in vbox

Timestamp:

Jun 19, 2019 5:50:27 AM (6 years ago)

Author:

vboxsync

Message:

VMM/HMVMXR0: Nested VMX: bugref:9180 On way back to ring-3, don't assert about VM-entry interruption info valid bit if the VM-entry failed (e.g, due to invalid-guest state)..

File:

• trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMR0/HMVMXR0.cpp

@@ -8888 +8888 @@
          * This can be pretty hard to debug otherwise, interrupts might get injected twice
          * occasionally, see @bugref{9180#c42}.
+         *
+         * However, if the VM-entry failed, any VM entry-interruption info. field would
+         * be left unmodified as the event would not have been injected to the guest. In
+         * such cases, don't assert, we're not going to continue guest execution anyway.
          */
+        uint32_t uExitReason;
         uint32_t uEntryIntInfo;
-        int rc = VMXReadVmcs32(VMX_VMCS32_CTRL_ENTRY_INTERRUPTION_INFO, &uEntryIntInfo);
+        int rc = VMXReadVmcs32(VMX_VMCS32_RO_EXIT_REASON, &uExitReason);
+        rc    |= VMXReadVmcs32(VMX_VMCS32_CTRL_ENTRY_INTERRUPTION_INFO, &uEntryIntInfo);
         AssertRC(rc);
-        Assert(!VMX_ENTRY_INT_INFO_IS_VALID(uEntryIntInfo));
+        Assert(VMX_EXIT_REASON_HAS_ENTRY_FAILED(uExitReason) || !VMX_ENTRY_INT_INFO_IS_VALID(uEntryIntInfo));
     }
 #endif