Changeset 79254 in vbox for trunk/src/VBox

Timestamp:

Jun 20, 2019 2:27:10 AM (6 years ago)

Author:

vboxsync

Message:

Main/GuestFileImpl.cpp: Reverted r128569 as comments alone can't fix buggy code (see failing 'offset' check after readAt test) or answer design critique. bugref:9320

File:

• trunk/src/VBox/Main/src-client/GuestFileImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/src-client/GuestFileImpl.cpp

@@ -297 +297 @@
     AutoReadLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    /* mData.mOffCurrent gets updated on i_readData[At]() / i_writeData[At]() file notification callbacks.
-     * So no need to take another roundtrip into the guest asking for the current offset (using tell). */
+/** @todo r=bird: Why do you have both a offset and a tell() function?
+ * After a ReadAt or WriteAt with a non-current offset, the tell() result will
+ * differ from this value, because mOffCurrent is only ever incremented with
+ * data read or written.  */
     *aOffset = mData.mOffCurrent;