Changeset 79285 in vbox

Timestamp:

Jun 21, 2019 9:52:34 PM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

131484

Message:

Main/GuestFileImpl.cpp: Translate FileAccessMode_AppendOnly and AppendRead to 'a' and 'a+' respectively and let the guest side do the invalid parmaeter bit if too old. bugref:9320

Location:

trunk/src/VBox/Main

Files:

• include/GuestCtrlImplPrivate.h (modified) (1 diff)
• src-client/GuestFileImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/include/GuestCtrlImplPrivate.h

@@ -623 +623 @@
     /** Extended open flags (currently none defined). */
     uint32_t                mfOpenEx;
-    /** Initial file offset. */
-    uint64_t                muOffset; /** @todo Remove this in the next protocol version. */
 };
 

trunk/src/VBox/Main/src-client/GuestFileImpl.cpp

@@ -664 +664 @@
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    LogFlowThisFunc(("strFile=%s, enmAccessMode=0x%x, enmOpenAction=0x%x, uCreationMode=%RU32, mfOpenEx=%RU32\n",
+    LogFlowThisFunc(("strFile=%s, enmAccessMode=%d, enmOpenAction=%d, uCreationMode=%o, mfOpenEx=%#x\n",
                      mData.mOpenInfo.mFilename.c_str(), mData.mOpenInfo.mAccessMode, mData.mOpenInfo.mOpenAction,
                      mData.mOpenInfo.mCreationMode, mData.mOpenInfo.mfOpenEx));
@@ -691 +691 @@
         case FileAccessMode_WriteOnly:  pszAccessMode = "w";  break;
         case FileAccessMode_ReadWrite:  pszAccessMode = "r+"; break;
-        case FileAccessMode_AppendOnly: RT_FALL_THRU();
-        case FileAccessMode_AppendRead: return VERR_NOT_IMPLEMENTED;
+        case FileAccessMode_AppendOnly: pszAccessMode = "a";  break;
+        case FileAccessMode_AppendRead: pszAccessMode = "a+"; break;
         default:                        return VERR_INVALID_PARAMETER;
     }
@@ -738 +738 @@
     HGCMSvcSetStr(&paParms[i++], pszSharingMode);
     HGCMSvcSetU32(&paParms[i++], mData.mOpenInfo.mCreationMode);
-    HGCMSvcSetU64(&paParms[i++], mData.mOpenInfo.muOffset);
+    HGCMSvcSetU64(&paParms[i++], 0 /*unused offset*/);
     /** @todo Next protocol version: add flags, replace strings, remove initial offset. */