Changeset 79287 in vbox for trunk/src/VBox/Main

Timestamp:

Jun 22, 2019 12:05:44 AM (6 years ago)

Author:

vboxsync

Message:

GuestCtrlSvc,Main,VBoxService: Implemented IGuestFile::SetSize. bugref:9320

Location:

trunk/src/VBox/Main

Files:

• idl/VirtualBox.xidl (modified) (2 diffs)
• src-client/GuestFileImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/idl/VirtualBox.xidl

@@ -23672 +23672 @@
       </desc>
     </const>
+    <const name="OnGuestFileSizeChanged" value="103">
+      <desc>
+        See <link to="IGuestFileSizeChangedEvent">IGuestFileSizeChangedEvent</link>.
+      </desc>
+    </const>
     <!-- End event marker -->
     <!-- @todo rename to 'End' as it is exclusive (we use 'last' to be inclusive). -->
-    <const name="Last" value="103">
+    <const name="Last" value="104">
       <desc>
         Must be last event, used for iterations and structures relying on numerical event values.
@@ -24953 +24958 @@
     >
     <desc>
-      Notification when a guest file changed its current offset.
+      Notification when a guest file changed its current offset via <link to="IFile::seek" />.
     </desc>
 
     <attribute name="midlDoesNotLikeEmptyInterfaces" readonly="yes" type="boolean"/>
   </interface>
+
+  <interface
+    name="IGuestFileSizeChangedEvent" extends="IGuestFileEvent"
+    uuid="d78374e9-486e-472f-481b-969746af2480"
+    wsmap="managed" autogen="VBoxEvent" id="OnGuestFileSizeChanged"
+    >
+    <desc>
+      Notification when a guest file changed its size via <link to="IFile::setSize" />.
+    </desc>
+
+    <attribute name="newSize" readonly="yes" type="long long"/>
+  </interface>
+
 
   <interface

trunk/src/VBox/Main/src-client/GuestFileImpl.cpp

@@ -41 +41 @@
 #include <VBox/com/array.h>
 #include <VBox/com/listeners.h>
+#include <VBox/AssertGuest.h>
 
 
@@ -584 +585 @@
         }
 
+        case GUEST_FILE_NOTIFYTYPE_SET_SIZE:
+            ASSERT_GUEST_MSG_STMT_BREAK(pSvcCbData->mParms == 4, ("mParms=%u\n", pSvcCbData->mParms),
+                                        rc = VERR_WRONG_PARAMETER_COUNT);
+            ASSERT_GUEST_MSG_STMT_BREAK(pSvcCbData->mpaParms[idx].type == VBOX_HGCM_SVC_PARM_64BIT,
+                                        ("type=%u\n", pSvcCbData->mpaParms[idx].type),
+                                        rc = VERR_WRONG_PARAMETER_TYPE);
+            dataCb.u.SetSize.cbSize = pSvcCbData->mpaParms[idx].u.uint64;
+            Log3ThisFunc(("cbSize=%RU64\n", dataCb.u.SetSize.cbSize));
+
+            fireGuestFileSizeChangedEvent(mEventSource, mSession, this, dataCb.u.SetSize.cbSize);
+            rc = VINF_SUCCESS;
+            break;
+
         default:
             break;
@@ -1518 +1532 @@
 HRESULT GuestFile::setSize(LONG64 aSize)
 {
-    RT_NOREF(aSize);
-    ReturnComNotImplemented();
+    LogFlowThisFuncEnter();
+
+    /*
+     * Validate.
+     */
+    if (aSize < 0)
+        return setError(E_INVALIDARG, tr("The size (%RI64) cannot be a negative value"), aSize);
+
+    /*
+     * Register event callbacks.
+     */
+    int             vrc;
+    GuestWaitEvent *pWaitEvent = NULL;
+    GuestEventTypes lstEventTypes;
+    try
+    {
+        lstEventTypes.push_back(VBoxEventType_OnGuestFileStateChanged);
+        lstEventTypes.push_back(VBoxEventType_OnGuestFileSizeChanged);
+    }
+    catch (std::bad_alloc &)
+    {
+        return E_OUTOFMEMORY;
+    }
+
+    AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
+
+    vrc = registerWaitEvent(lstEventTypes, &pWaitEvent);
+    if (RT_SUCCESS(vrc))
+    {
+        /*
+         * Send of the HGCM message.
+         */
+        VBOXHGCMSVCPARM aParms[3];
+        HGCMSvcSetU32(&aParms[0], pWaitEvent->ContextID());
+        HGCMSvcSetU32(&aParms[1], mObjectID /* File handle */);
+        HGCMSvcSetU64(&aParms[2], aSize);
+
+        alock.release(); /* Drop write lock before sending. */
+
+        vrc = sendMessage(HOST_MSG_FILE_SET_SIZE, RT_ELEMENTS(aParms), aParms);
+        if (RT_SUCCESS(vrc))
+        {
+            /*
+             * Wait for the event.
+             */
+            VBoxEventType_T enmEvtType;
+            ComPtr<IEvent>  pIEvent;
+            vrc = waitForEvent(pWaitEvent, RT_MS_1MIN / 2, &enmEvtType, pIEvent.asOutParam());
+            if (RT_SUCCESS(vrc))
+            {
+                if (enmEvtType == VBoxEventType_OnGuestFileSizeChanged)
+                    vrc = VINF_SUCCESS;
+                else
+                    vrc = VWRN_GSTCTL_OBJECTSTATE_CHANGED;
+            }
+            if (RT_FAILURE(vrc) && pWaitEvent->HasGuestError()) /* Return guest rc if available. */
+                vrc = pWaitEvent->GetGuestError();
+        }
+
+        /*
+         * Unregister the wait event and deal with error reporting if needed.
+         */
+        unregisterWaitEvent(pWaitEvent);
+    }
+    HRESULT hrc;
+    if (RT_SUCCESS(vrc))
+        hrc = S_OK;
+    else
+        hrc = setErrorBoth(VBOX_E_IPRT_ERROR, vrc, tr("Setting the file size of '%s' to %RU64 (%#RX64) bytes failed: %Rrc"),
+                           mData.mOpenInfo.mFilename.c_str(), aSize, aSize, vrc);
+    LogFlowFuncLeaveRC(vrc);
+    return hrc;
 }