Changeset 79345 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

Jun 26, 2019 9:09:46 AM (6 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

131577

Message:

VMM/HM: Nested VMX: bugref:9180 Implemented VMCS shadowing.

File:

• trunk/src/VBox/VMM/VMMAll/HMVMXAll.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMAll/HMVMXAll.cpp

@@ -1232 +1232 @@
  *
  * @param   pVCpu   The cross context virtual CPU structure.
- * @param   pCtx    Pointer to the guest-CPU context.
  *
  * @remarks Can be called from ring-0 as well as ring-3.
  */
-VMM_INT_DECL(void) HMNotifyVmxNstGstVmexit(PVMCPU pVCpu, PCPUMCTX pCtx)
-{
-    NOREF(pCtx);
-
+VMM_INT_DECL(void) HMNotifyVmxNstGstVmexit(PVMCPU pVCpu)
+{
     /*
      * Transitions to ring-3 flag a full CPU-state change except if we transition to ring-3
@@ -1249 +1246 @@
      * for the nested-guest from ring-3.
      *
-     * Flag reloading of just the guest-CPU state is -not- sufficient since HM also needs
-     * to reload related state with VM-entry/VM-exit controls and so on. Flag reloading
-     * the entire state.
+     * Signalling reload of just the guest-CPU state that changed with the VM-exit is -not-
+     * sufficient since HM also needs to reload state related to VM-entry/VM-exit controls
+     * etc. So signal reloading of the entire state. It does not seem worth making this any
+     * more fine grained at the moment.
      */
     CPUM_ASSERT_NOT_EXTRN(pVCpu, CPUMCTX_EXTRN_ALL);
@@ -1258 +1256 @@
     /*
      * Make sure we need to merge the guest VMCS controls with the nested-guest
-     * VMCS controls on the next nested-guest VM entry.
+     * VMCS controls on the next nested-guest VM-entry.
      */
     pVCpu->hm.s.vmx.fMergedNstGstCtls = false;
 }
+
+
+/**
+ * Notification callback for when the guest hypervisor's current VMCS is loaded or
+ * changed outside VMX R0 code (e.g. in IEM).
+ *
+ * This need -not- be called for modifications to the guest hypervisor's current
+ * VMCS when the guest is in VMX non-root mode as VMCS shadowing is not applicable
+ * there.
+ *
+ * @param   pVCpu   The cross context virtual CPU structure.
+ *
+ * @remarks Can be called from ring-0 as well as ring-3.
+ */
+VMM_INT_DECL(void) HMNotifyVmxNstGstCurrentVmcsChanged(PVMCPU pVCpu)
+{
+    CPUM_ASSERT_NOT_EXTRN(pVCpu, CPUMCTX_EXTRN_HWVIRT);
+    ASMAtomicUoOrU64(&pVCpu->hm.s.fCtxChanged, CPUMCTX_EXTRN_HWVIRT);
+
+    /*
+     * Make sure we need to copy the guest hypervisor's current VMCS into the shadow VMCS
+     * on the next guest VM-entry.
+     */
+    pVCpu->hm.s.vmx.fCopiedNstGstToShadowVmcs = false;
+}
+
 # endif /* VBOX_WITH_NESTED_HWVIRT_VMX */
 #endif /* IN_RC */